Comments (3)
It looks good to me (and I believe it should work just fine). Do you want to submit a pull request?
Just a couple things:
-
changes: SimpleChanges
,email: string
-
Unchanged properties won't be sent through
ngOnchanges
if (changes['email']) {
...
}
Edit
For your own personal case I'd probably use <ng-container>
instead. You don't really want to display a broken image.
<ng-container *ngIf="imageSrc">
<img gravatar ...
</ng-container>
from ng2-gravatar.
@abalad Thank you for contributing, PR is merged and npm package published.
from ng2-gravatar.
@zurfyx That's really what I ended up doing. But I think it would be interesting to change it in the OnChanges event.
Anyway I sent a PR. Thank you so much
from ng2-gravatar.
Related Issues (8)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ng2-gravatar.