Giter Site home page Giter Site logo

Comments (3)

zurfyx avatar zurfyx commented on August 17, 2024 1

It looks good to me (and I believe it should work just fine). Do you want to submit a pull request?

Just a couple things:

  1. changes: SimpleChanges, email: string

  2. Unchanged properties won't be sent through ngOnchanges

if (changes['email']) {
  ...
}

Edit

For your own personal case I'd probably use <ng-container> instead. You don't really want to display a broken image.

<ng-container *ngIf="imageSrc">
  <img gravatar ...
</ng-container>

from ng2-gravatar.

tb avatar tb commented on August 17, 2024 1

@abalad Thank you for contributing, PR is merged and npm package published.

from ng2-gravatar.

abalad avatar abalad commented on August 17, 2024

@zurfyx That's really what I ended up doing. But I think it would be interesting to change it in the OnChanges event.

Anyway I sent a PR. Thank you so much

from ng2-gravatar.

Related Issues (8)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.