Fails on mvn clean install

[tbroyer]

Fails on mvn clean install

[tbroyer]

This is due to using Java 9 or Java 10. Dagger will then annotate its generated classes with java.annotation.processing.Generated which GWT won't find (I have no idea yet why it won't find it; even when using GWT's HEAD-SNAPSHOT version with -sourceLevel 9 or -sourceLevel 10`).

Passing <release>8</release> fixes the build, in Java 9+, by forcing Dagger to use javax.annotation.Generated instead, but would break it in Java 8 as the maven-compiler-plugin unconditionally passes it to JavaC so it has to be set in a profile activated by the JDK version.

[tbroyer]

Note: using Dagger 2.15 also fixes the problem in the case of this archetype, as Dagger 2.15 will now respect -source 1.8 -target 1.8 passed by the maven-compiler plugin.

[tbroyer]

I reported the issue upstream (gwtproject/gwt#9612) and will update the archetype to Dagger 2.15.

[mduesbury]

Thanks :) Get Outlook for iOS<https://aka.ms/o0ukef>

…

________________________________ From: Thomas Broyer <[email protected]> Sent: Tuesday, April 24, 2018 3:43:17 PM To: tbroyer/gwt-maven-archetypes Cc: mduesbury; Author Subject: Re: [tbroyer/gwt-maven-archetypes] Fails on mvn clean install (#54) I reported the issue upstream (gwtproject/gwt#9612<https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fgwtproject%2Fgwt%2Fissues%2F9612&data=02%7C01%7C%7C3d775e2ce1a1497c3a4c08d5a9f1b835%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636601777989152202&sdata=P%2FAc9w%2BKbqVpWy2bdKZCrzrp078hD3mTveMLJPu11%2Fs%3D&reserved=0>) and will update the archetype to Dagger 2.15. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftbroyer%2Fgwt-maven-archetypes%2Fissues%2F54%23issuecomment-383958724&data=02%7C01%7C%7C3d775e2ce1a1497c3a4c08d5a9f1b835%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636601777989152202&sdata=OsV5Or7GEmr5VFL1KM1moeDu1IA2UvwJkVtRQv7mCoY%3D&reserved=0>, or mute the thread<https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABmJreGMqdiV8_vY0T6NZz0g6Cc4fZI8ks5trzoFgaJpZM4ThLLv&data=02%7C01%7C%7C3d775e2ce1a1497c3a4c08d5a9f1b835%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636601777989152202&sdata=g2u1tPng%2F8FrlskFOOxlPX79FVy4hVR7MqzzuF0hfF8%3D&reserved=0>.