Giter Site home page Giter Site logo

Comments (3)

tbroyer avatar tbroyer commented on May 24, 2024

This is because the maven-source-plugin is bound to the prepare-package (or even package) phase, which comes after the test phase. As you need sources for GWT tests, then either run source:jar earlier, or always run at least up until the prepare-package or package phase.

This is purely a Maven "issue" from my PoV, due to its linear lifecycle and how it's applied to reactor builds. I personally consider the only 2 phases you should use as goals when calling a multi-module build are package and verify. (install and deploy have specific uses --namely share the built artifacts with other projects, or working around ill-designed plugins or Maven lifecycle-- so does clean, obviously)

from gwt-maven-plugin.

ibaca avatar ibaca commented on May 24, 2024

Thanks! Using the package goal is ok.

Just one thing. Looks like you admit that the test goal is broken at the test phase (maven problem), why don't you set the default phase of the TestMojo to PREPARE_PACKAGE (or PACKAGE) so is clear that the plugin requires at least this phase to work properly. Or one step further, use INTEGRATION_TEST which solve the problem and is still meaningful.

from gwt-maven-plugin.

tbroyer avatar tbroyer commented on May 24, 2024

Because the test phase is when it's appropriate to run tests, and it works OK on one module. The problem arises in multi-module builds when you have dependencies on non-gwt modules where the maven-source-plugin is used. The proper fix (if you want it) is to run source:jar earlier, or just always use package at a minimum in multi-module builds.

from gwt-maven-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.