Giter Site home page Giter Site logo

Comments (8)

branflake2267 avatar branflake2267 commented on May 24, 2024

Here is what I would expect the goal to do, copy the super source into the classes directory, except it doesn't do it with only running mvn gwt:add-super-sources.

screen shot 2015-12-31 at 11 30 51 pm

from gwt-maven-plugin.

branflake2267 avatar branflake2267 commented on May 24, 2024

Looks like a MavenResourcesExecution needs to be invoked in the execute path.

from gwt-maven-plugin.

branflake2267 avatar branflake2267 commented on May 24, 2024

I copied MavenResourcesExecution from import sources into add super sources mojo execution path, and it worked. Is this something you can fix or would you like me to try to add a PR for it tomorrow?

from gwt-maven-plugin.

tbroyer avatar tbroyer commented on May 24, 2024

gwt:add-super-sources only declares a <resource> programmatically so that we can have sane defaults in the lifecycles. The actual copy is done by resources:resources in the process-resources phase (like in any standard Maven project with packaging jar or war).

FYI, the only reason gwt:import-sources does the copying is that it needs to run after the process-resources phase to be able to pick up generated sources (specifically by annotation processors during the compile phase).

from gwt-maven-plugin.

branflake2267 avatar branflake2267 commented on May 24, 2024

Gotcha. I was expecting to run the goal by itself and have it move the resources too. I think it would add some flexibility to the plugin. While I understand the ideal behavior would be not to add the resources twice on some paths of execution I don't see why it wouldn't be a problem to do it all in the goal too. This makes it troublesome to find a good execution path for m2e. I haven't found any workable path yet which means I have to look at other options if I can get anything to work with this plugin.

from gwt-maven-plugin.

tbroyer avatar tbroyer commented on May 24, 2024

What's the actual problem with m2e? What does it do (and when) that makes it incompatible with this behavior? Why do you need/want super sources copied to project.build.outputDirectory without also copying other resources?

from gwt-maven-plugin.

branflake2267 avatar branflake2267 commented on May 24, 2024

After you mentioned it should be copied in the resources phases got me to thinking it might be getting wiped so I'm trying to determine if I've got a race condition with another plugin.

M2e in eclipse will add goals to the lifecycles to run. So I need to add the super sources into the classes, so I add the goal gwt:add-super-sources into the pom, which I see m2e picks up. I know it executes it, although since its only adding the resources to the maven project. From what it looks like it's either running after the resources execution, or it's a completely different config its adding the reference to the resources to. The module is generating at the same time, and I see it get added to the classes.

All I really want is the super source get copied to the classes and I'll I want to do is add the goal to the plugin and have m2e pick that up and run it which it's doing it. But that goal I found like you said, is depending on resources:resources running another plugin. This I don't know how works yet, at least I don't know how and when m2e is running resources.

from gwt-maven-plugin.

branflake2267 avatar branflake2267 commented on May 24, 2024

I've been trying to avoid setting up the resource definition with the directory src/main/super, which fixes it. I've tried to avoid that b/c it adds the source folder to the ide, and then errors start to show up, but I forget, that resources are excluded by default. Ugh, so many layers I forget about.

from gwt-maven-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.