Comments (8)
This is a great use. Thanks. Can you post a pointer to the code so that we can try enhancing it with weak ref code? I will be interested in trying the proposed weakref approach and trying it with various weak collection options.
Also, is there anything in the standard or other source of desire/requirement for making a similar cleanup step if the node is just dropped on the floor (e.g., some incidental additional value in triggering the cleanup).
from proposal-weakrefs.
+1 to "iterable weak set", as another use case I have heard is implementing the "become" operator in languages like Smalltalk.
Is it possible to change the title of an issue? If so, I suggest adding "iterable weak set" to the title here.
from proposal-weakrefs.
I got a rather simple other usecase, I've objects representing points in a 2d plane, I like to freeze them and I would like to intern them, so a simple a === b would test them for equality. For this I'd put all the points generated in a weak table with some kind of hash value to test if this object already exists before creating a new one. Similar for objects representing lines or other geometric objects.
from proposal-weakrefs.
@dtribble the code is in roughly these locations:
- https://github.com/jsdom/jsdom/blob/a0b7f8a77789fbc4467031a19865a2d1aef27796/lib/jsdom/living/nodes/Document-impl.js#L740-L750
- https://github.com/jsdom/jsdom/blob/a0b7f8a77789fbc4467031a19865a2d1aef27796/lib/jsdom/living/nodes/Document-impl.js#L624-L628
- https://github.com/jsdom/jsdom/blob/a0b7f8a77789fbc4467031a19865a2d1aef27796/lib/jsdom/living/nodes/Node-impl.js#L313-L315
- https://github.com/jsdom/jsdom/blob/a0b7f8a77789fbc4467031a19865a2d1aef27796/lib/jsdom/living/traversal/NodeIterator-impl.js#L78-L84
I'm not sure which node you'd be referring to in "is there anything in the standard or other source of desire/requirement for making a similar cleanup step if the node is just dropped on the floor", but I don't think there is any such desire/requirement.
@titzer I'm not sure why we'd call out the iterable weak set API shape specifically here; this could be accomplished with any API shape, from the proposal's weak ref, to an iterable weak map, to an iterable weak set, ...
from proposal-weakrefs.
@domenic I simply meant using "iterable weak set" in a conceptual sense to summarize the use case described here, not any particular API commitment.
from proposal-weakrefs.
Ah OK, sure, I'll do that if you think that there's a tie between a generalization of this use case and the API shape.
from proposal-weakrefs.
@mathiasbynens wrote up something related to this use case in the explainer. Is there anything else to add, or is it OK to close this issue?
from proposal-weakrefs.
Closing due to #17 (comment)
from proposal-weakrefs.
Related Issues (20)
- README feedback from @jorendorff HOT 1
- HostCleanupFinalizationGroup needs to pick a VM decided max iteration count HOT 30
- Should the fg copy the empty cells before calling cleanup callback? HOT 4
- Add API summary to README.md HOT 2
- Use of 'Job' in KeepDuringJob is misleading HOT 4
- Problem with definition of liveness HOT 12
- Rename FinalizationGroup to FinalizationRegistry (or other name?) HOT 5
- Document FinalizationGroup independent lifetime
- Soft check for WeakRef with reclaimed referent? HOT 15
- makeWeakCached passes key for unregister token; keys are often primitives HOT 1
- Document expectations of WeakRef behavior in practice HOT 3
- Documentation should encourage people to use cleanupSome only when appropriate HOT 2
- cleanupSome on main thread questions HOT 18
- Guarantee finalizers being called soonish. HOT 3
- Is this proposal stable enough for other specs to make use of weak refs? HOT 8
- The WeakRef object can also cause memory leak, why not make the reference self null? HOT 6
- WeakRef.prototype.deref() is misnamed HOT 17
- Iterable WeakMap implementation in README is incorrect?
- Q: Why not to add `getKeys() : array` instead? HOT 5
- Will heldValue be GC, after cleanupCallback executed? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from proposal-weakrefs.