Giter Site home page Giter Site logo

Comments (8)

fangel avatar fangel commented on May 23, 2024

Agreed. That would be rather cool.

from atom-message-panel.

joefitzgerald avatar joefitzgerald commented on May 23, 2024

I would like max-height to be something that can be expressed as a percentage on initialization of the MessagePanelView. It should be resizable for all percentages < 100% (at 100% the pane should be used to resize instead) and it should default to collapsing to the available content's size if that content occupies less than the max-height percentage.

25% sounds like a nice default percentage, assuming the panel collapses to available content by default.

from atom-message-panel.

tcarlsen avatar tcarlsen commented on May 23, 2024

We need to be able to return this value to the package so it can be stored in a config file, so the user don't have to resize every single time they use the package

from atom-message-panel.

joefitzgerald avatar joefitzgerald commented on May 23, 2024

Should storing defaults about the panel be something that is done once for all packages that use it, or once per package that use it?

from atom-message-panel.

tcarlsen avatar tcarlsen commented on May 23, 2024

I believe we just should return the value to the package and then let it up to the package developer how to use this value.

I don't see us storing the value over all packages, where will be packages where you what to see more lines then in other packages

from atom-message-panel.

joefitzgerald avatar joefitzgerald commented on May 23, 2024

👍

from atom-message-panel.

tcarlsen avatar tcarlsen commented on May 23, 2024

moving this to milestone 1.2.0, we need to release 1.1.0

from atom-message-panel.

tcarlsen avatar tcarlsen commented on May 23, 2024

#62 should add this functionality ecept the (send the value back to the package)

from atom-message-panel.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.