Giter Site home page Giter Site logo

Warning that should be removed about span HOT 2 CLOSED

tcbrindle avatar tcbrindle commented on June 9, 2024
Warning that should be removed

from span.

Comments (2)

tcbrindle avatar tcbrindle commented on June 9, 2024

Thanks for the info. What compiler/warning level combination triggers a warning in this case?

I think I'd prefer std::size_t dynamic_extent = std::size_t(-1), but looking at the standard text it actually uses std::numeric_limits<std::size_t>::max(), so perhaps that's what we should go for.

from span.

brandl-muc avatar brandl-muc commented on June 9, 2024

With MSVC with warning level 4 this leads to the following:
warning C4245: 'initializing': conversion from 'int' to 'size_t', signed/unsigned mismatch
Also see this online example.

We compile with /W4 and warnings as errors, so we can't use span out of the box. (thanks for the work btw)

Although there don't seem to be any implementations that don't use two's complement and there are afaik ideas to make the abstract machine two's compement currently using -1 is non-compliant. Same goes for ~0 of course.
I'd propose using SIZE_MAX or in case you don't want to add the extra header std::size_t{} - 1u should also work because modular arithmetics are guaranteed for unsigned types.

from span.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.