"max buffer exceeded" error

[tdewolff]

"max buffer exceeded" error

[kokizzu]

The code:

js := bytes.Buffer{}
dat, err := ioutil.ReadFile(fname)
if L.Check(err, `File doesn't exists: `+fname) == nil {
  dat, err = min.MinifyBytes(`text/js`, dat)
  js.Write(dat) 
  js.WriteRune(';')
}

[tdewolff]

I cannot reproduce, are you sure you update tdewolff/parse lately for I pushed tdewolff/parse@9e980e5 with a bugfix.

[kokizzu]

Yes, the error still the same..

[kokizzu]

minimum code to reproduce:

package main

import `fmt`
import `io/ioutil`
import `github.com/tdewolff/minify`
import `github.com/tdewolff/minify/js`

func main() {
    min := minify.NewMinifier()
    min.Add("text/js", js.Minify)
    fname := `/tmp/ace.js`
    dat, err := ioutil.ReadFile(fname)
    if err == nil {
        dat, err = min.MinifyBytes(`text/js`, dat)
        if err == nil {
            fmt.Println(`ok`)
        } else {
            fmt.Printf("%# v\n", err)
        }
    } else {
        fmt.Printf("%# v\n", err)
    }
}

output:

&errors.errorString{s:"max buffer exceeded"}

ace.js downloaded from https://raw.githubusercontent.com/ajaxorg/ace-builds/master/src/ace.js

[tdewolff]

The problem is that ace.js contains a very very long string which exceeds the maximum buffer limit. This limit is set to 4096 bytes in https://github.com/tdewolff/parse/blob/master/shiftbuffer.go#L10

But the string is 11508 characters long, I drastically increased the limit, but one can do this manually too. tdewolff/parse@dd3690f

Additionally, this is fixed by 69eb7cf by using the provided slice which sets no size limit.