Giter Site home page Giter Site logo

Comments (3)

ttttmr avatar ttttmr commented on May 26, 2024

parse/js/ast.go

Lines 1053 to 1072 in 2c5882a

func (n BindingObjectItem) String() string {
s := ""
if n.Key != nil {
if v, ok := n.Value.Binding.(*Var); !ok || !n.Key.IsIdent(v.Data) {
s += " " + n.Key.String() + ":"
}
}
return " " + n.Value.String()
}
// JS converts the node back to valid JavaScript
func (n BindingObjectItem) JS() string {
s := ""
if n.Key != nil {
if v, ok := n.Value.Binding.(*Var); !ok || !n.Key.IsIdent(v.Data) {
s += " " + n.Key.JS() + ":"
}
}
return " " + n.Value.JS()
}

There seems to be something strange here, the s variable is not returned, and the data of n.Key seems to be lost

from parse.

ttttmr avatar ttttmr commented on May 26, 2024

parse/js/ast.go

Lines 1887 to 1900 in 2c5882a

func (n CallExpr) String() string {
if n.Optional {
return "(" + n.X.String() + "?." + n.Args.String() + ")"
}
return "(" + n.X.String() + n.Args.String() + ")"
}
// JS converts the node back to valid JavaScript
func (n CallExpr) JS() string {
if n.Optional {
return n.X.String() + "?.(" + n.Args.JS() + ")"
}
return n.X.JS() + "(" + n.Args.JS() + ")"
}

Here the JS() method calls n.X.String(), should we use n.X.JS()

from parse.

tdewolff avatar tdewolff commented on May 26, 2024

Valid remarks, I've incorporated the fixes!

from parse.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.