[Bug] Socket Message CLIENT_READY is not being logged properly

[team-telnyx]

[Bug] Socket Message CLIENT_READY is not being logged properly

[icodelifee]

I've been scratching my head over this issue for a couple of days now.
Is there a way to know if the client has been logged in through the client class? because I'm relying on registered state variable in my notifier class which updates when observer triggers CLIENT_READY case to know that i have logged in and is ready to make calls

[Oliver-Zimmerman]

hey @icodelifee.

I can look into this for you - generally, though, the REGED state is what you should be looking for in terms of when the client is ready to make and receive calls.

[icodelifee]

hey @icodelifee.

I can look into this for you - generally, though, the REGED state is what you should be looking for in terms of when the client is ready to make and receive calls.

Yes, i know about REGED but the observer onSocketMessage handler is not logging any messages.

[icodelifee]

Hello, @Oliver-Zimmerman im having another issue, Websocket automatically closes. for now, i have a workaround, a timer which checks every couple of seconds if the telnyx client is connected or not.
Should i create another issue?. logs below thanks.
https://katb.in/opafixoqisu

Update: got a close with close reason

[Oliver-Zimmerman]

@icodelifee sorry for the late reply, the mobile team is under heavy load at the moment. This is my priority today. I will look into both issues. and update you here

[Oliver-Zimmerman]

@icodelifee Can I ask if you are testing on iOS, Android or Web? Or is it happening on all?

[Oliver-Zimmerman]

Hey @icodelifee

In regards to the socket closing. This should be fixed by this PR
#21

I can let you know once it has merged and we do a release, but you should be able to test it from there first if you like.

In regards to the client ready message. There might be some confusion as to how onSocketMessageReceived works.

I believe you are receiving Client Ready but are perhaps only looking at the message instead of the SocketMethod provided with the message. For example here is the Client_Ready socket method we receive on a successful REGED state:

We monitor this in our view model in the sample app like this, regardless of the containing message:

[Oliver-Zimmerman]

https://pub.dev/packages/telnyx_webrtc

The new version is available @icodelifee

telnyx_webrtc: ^0.0.8

Please close this issue if it is resolved, otherwise let me know here and we can investigate further

[icodelifee]

both issues. and update you here

Im testing on Android

[icodelifee]

Hey @icodelifee

In regards to the socket closing. This should be fixed by this PR #21

I can let you know once it has merged and we do a release, but you should be able to test it from there first if you like.

In regards to the client ready message. There might be some confusion as to how onSocketMessageReceived works.

I believe you are receiving Client Ready but are perhaps only looking at the message instead of the SocketMethod provided with the message. For example here is the Client_Ready socket method we receive on a successful REGED state:

We monitor this in our view model in the sample app like this, regardless of the containing message:

Oh, i also observe all the Telnyx messages using the messageRecieved handler

[icodelifee]

In the latest version im getting a stream sink close issue

[icodelifee]

In the latest version im getting a stream sink close issue

After this error gets thrown, the messageReceived callback is not working

[Oliver-Zimmerman]

@icodelifee I can't reproduce this. Can you confirm it is happening on the sample app too? If not then I believe we need to look into your implementation.

I've had an application up and running for over 30 minutes now without the error:
https://pastebin.pl/view/cb847a9e

[icodelifee]

@icodelifee I can't reproduce this. Can you confirm it is happening on the sample app too? If not then I believe we need to look into your implementation.

I've had an application up and running for over 30 minutes now without the error: pastebin.pl/view/cb847a9e

Its still happening, but only after i call from SIP number to my SIP number, i still dont know the correct way to reproduce it!, maybe the websocket closed and its trying to access it? before its being reconnected? im not sure

[icodelifee]

@icodelifee I can't reproduce this. Can you confirm it is happening on the sample app too? If not then I believe we need to look into your implementation.
I've had an application up and running for over 30 minutes now without the error: pastebin.pl/view/cb847a9e

Its still happening, but only after i call from SIP number to my SIP number, i still dont know the correct way to reproduce it!, maybe the websocket closed and its trying to access it? before its being reconnected? im not sure

One thing i found is that it only happens after the debug message ->
Received WebSocket message - Contains Method :: {jsonrpc: 2.0, id: 17786, method: telnyx_rtc.ping, params: {serno: 1665048277}}, if that can help

https://katb.in/acaserufema

[Oliver-Zimmerman]

Okay I will test after receiving a call and see if I can reproduce. I will update you here

[Oliver-Zimmerman]

@icodelifee and you're sure this is happening on the Sample app? I just ran a test logging in and receiving a call and then waiting for 2 successful Ping/Pong exchanges and it seems to be working. Video attached:

Screen.Recording.2022-10-06.at.11.04.11.mov

[icodelifee]

@icodelifee and you're sure this is happening on the Sample app? I just ran a test logging in and receiving a call and then waiting for 2 successful Ping/Pong exchanges and it seems to be working. Video attached:

Screen.Recording.2022-10-06.at.11.04.11.mov

Hey, i did some more testing, its fine the example app, i think its happening because i close the websocket after user logout.
Is it necessary to disconnect the websocket when user sign out of the app and then relogs with a different credentials?

[Oliver-Zimmerman]

Hey @icodelifee

No that's not necessary. You can keep the same socket connection alive and just send another login message with the different credentials.

However, closing the socket theoretically shouldn't cause any issues if you then reopen it. I can look into this flow for you and see what is causing the issue. But for now, feel free to simply login with different credentials

[Oliver-Zimmerman]

hey @icodelifee

I found the issue with the disconnect. You can see the PR here. I will release a new version soon:
#22

[Oliver-Zimmerman]

@icodelifee

Version 0.0.9 has been released. You should be able to use disconnect now.

Please close this issue if it is working for you

[Oliver-Zimmerman]

@icodelifee I am going to close this for now. Please re-open if the issue persists