the order of remote autogenerated bookmarked playlists changes when they are opened

[ajgae]

the order of remote autogenerated bookmarked playlists changes when they are opened

[ajgae]

reopening as a new issue from a discussion on #10993, as suggested by @opusforlife2. Here is the state of my research on the topic so far:

• the getPlaylists() queries in the RemotePlaylistDAO and local playlist DAO classes seem to be ordered by display index, as expected, which lets me think that the issue is with either merge logic or the updating of display indices, but not with the queries themselves
• the fact that only autogenerated remote playlists are affected is very strange and confuses me greatly
• the fact that remote playlists are sorted alphabetically before all other playlists may indicate that they share the same display index
• this line sets the display index to -1 for all remote playlists by default (which is strange, because newly bookmarked remote playlists do not appear at the top of the bookmarked playlists but at the bottom)
• the only place in the entire codebase where setDisplayIndex() is called on a PlaylistRemoteEntity is in BookmarkFragment.saveImmediate(), which is called by BookmarkFragment.onPause() (this corresponds with the moment at which the playlists are moved all the way up)
  • in saveImmediate(), debounceSaver.getIsModified() returns false so the function returns immediately. The code which computes and updates the display index for playlists is not executed. it seems that the issue is with the debounceSaver in some way, but i do not understand this part of the application very well

[ajgae]

you can consider that i working on this btw, I just won't have time in the next couple of days.

Here's a new specificity i observed about the behavior (shown in the video below): the buggy reordering is only triggered when the playlist is loaded. Once it has been loaded, opening it does not trigger the reordering

video_2024-04-30_11-05-52.mp4

[opusforlife2]

@ajgae If it's a small bug fix, easy to review, sure. Otherwise it might be postponed for, or after, the rewrite.