techdev-solutions/trackr-frontend

trackr-frontend's Issues

Replace "absolut" require paths with relative ones

At the moment all require paths are absolute to the base URL '/src'.
If the build system allows it they should be replaced with relative URLs to the current module which would greatly improve readability.
Example:

// src/modules/reportr/reportrModule.js
define(['angular',
    'modules/reportr/revenueController',
    'modules/reportr/vacationController',
...
// can be replaced with
define(['angular',
    './revenueController',
    './vacationController',
...

Rethink form errors in the angular app

The current solution is homemade (error-display directive), angular has built in functionality for errors in forms.

Show percentage hint in expense report

When entering a VAT to the expanses I erred by entering the monetary value instead of the percentage. A hint saying 'in percent' would help

Create a "Don't show if belongs to principal" directive

There are quite a few places where we put the principal object in the scope just to test for
ng-show="request.employee.id !== principal.id"
Instead we should have a directive like (name is WIP)
show-not-to-user="request.employee.id"

Repace <base href="/"> in the build process or make it configurable

When this tag does not match the path that a webserver uses to serve trackr it can lead to infite page reloads.
We had this in TeamCity with sed but that gets lost easily.