Giter Site home page Giter Site logo

Comments (3)

TechnikEmpire avatar TechnikEmpire commented on May 30, 2024

Its a simple call to IPAddress.NetworkToHostOrder and you should only be calling it once per condition for the lifetime of your application.

It makes little to no sense to force function calls every single time to covert naturally big endian values to little endian and incur performance penalties when a correctly engineered application doesn't need to do this.

Suggest you reengineer your app.

from windivertsharp.

kOchirasu avatar kOchirasu commented on May 30, 2024

If you do the conversion on value retrieval, there is no performance penalty unless the value is retrieved. Stuff like sequence number is different on every packet, are you telling me to manually increment a sequence number counter? Seems like unnecessary complexity to me.

from windivertsharp.

TechnikEmpire avatar TechnikEmpire commented on May 30, 2024

Alright granted but this is a wrapper around windivert and it doesn't auto convert. Idea was to stay close to the original design.

I'm writing my own kernel driver so I'm not investing anymore work into windivert.

from windivertsharp.

Related Issues (16)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.