Giter Site home page Giter Site logo

Comments (11)

tegon avatar tegon commented on May 29, 2024

Thank you for the feedback. My biggest concern about doing this is that some people might end up hitting the sync button without reviewing some items at the end, and end up adding some wrong things to their history. (I get a lot of complains about that, even though the button is at the end)
Although it seems like a good feature for people that always click on sync, I think it would cause more harm for most of the users.
What do you think? We can discuss more, I'm open to suggestions.

from traktflix.

vtdeleond avatar vtdeleond commented on May 29, 2024

from traktflix.

tegon avatar tegon commented on May 29, 2024

If I understood correctly, that wouldn't change much right? It will give more work to the user in the end also.
One idea that I have is to change the list size (today is 100 items per page, mostly because that's what Netflix returns) to a smaller number (like 20 or 10) you guys think It would be better?

from traktflix.

vtdeleond avatar vtdeleond commented on May 29, 2024

Hmm, could be (20)... but you'll have to handle every pagination with Netflix return.

Make the easier one

from traktflix.

tegon avatar tegon commented on May 29, 2024

Will be complex, for sure. I'll see if I can just duplicate it on top easily then.

from traktflix.

griffmiester avatar griffmiester commented on May 29, 2024

Alternate suggestion:
What if you added an Options page for the trakflix extension, so you can choose if you want the Sync button only at the bottom or at the top+bottom.
Maybe even add a warning message if they click the checkbox, that says something like:
"If you choose to include the Sync Button at the top of the page, I can't be held responsible for the unintentional duplication of syncing of watched shows to Trakt"

from traktflix.

tegon avatar tegon commented on May 29, 2024

Currently, I don't have a backend and the local chrome storage for extensions is limited, so the only thing I store is the Trakt's API access token. What do you think if the button's div had a position fixed, to it's always was visible?

screenshot 2017-02-22 13 26 54

from traktflix.

griffmiester avatar griffmiester commented on May 29, 2024

I like it, but it does then fail the "have you scrolled through and checked all that you are about to sync" issue.

from traktflix.

tegon avatar tegon commented on May 29, 2024

Yeah, I know. I will probably add a confirm dialog with a warning message.

from traktflix.

vtdeleond avatar vtdeleond commented on May 29, 2024

from traktflix.

tegon avatar tegon commented on May 29, 2024

Implemented on version 1.0.7.9

from traktflix.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.