Giter Site home page Giter Site logo

Comments (4)

TehShrike avatar TehShrike commented on May 23, 2024

So I guess before I dive in any further, the philosophical discussion - do we want the route to change to reflect any default states that are displayed?

I vaguely remember thinking about this in the past, and I guess I decided that I was fine with it not updating the route. But that's not terribly intuitive, so if we decide to keep it that way, at the very least the documentation should be made more clear.

Do you have any thoughts @ArtskydJ or @thebearingedge?

from abstract-state-router.

ArtskydJ avatar ArtskydJ commented on May 23, 2024

I think it should update the route to include the default child. If someone doesn't want that, they can maybe keep the route undefined, depending on how their states are set up.

  • Let's say you have state a that has the route /a with a default child of b that has the route /b with a default child of c that has the route /c.
  • Let's say that each of these routes have other children too.
  • The way it is now, if you go to #/a you get a nice short route.
  • The other way, if you go to #/a you get #/a/b/c. This could get long, and be considered ugly.
  • But the way it is now, #/a, #/a/b, and #/a/b/c all point to the same state. This could be confusing.

from abstract-state-router.

TehShrike avatar TehShrike commented on May 23, 2024

I think that states it well. I'm inclined to agree.

from abstract-state-router.

thebearingedge avatar thebearingedge commented on May 23, 2024

The hash should reflect the app state as much as possible. If I can set b as the default child of a but leave b's route undefined or as an empty string I'm good.

from abstract-state-router.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.