Comments (4)
So I guess before I dive in any further, the philosophical discussion - do we want the route to change to reflect any default states that are displayed?
I vaguely remember thinking about this in the past, and I guess I decided that I was fine with it not updating the route. But that's not terribly intuitive, so if we decide to keep it that way, at the very least the documentation should be made more clear.
Do you have any thoughts @ArtskydJ or @thebearingedge?
from abstract-state-router.
I think it should update the route to include the default child. If someone doesn't want that, they can maybe keep the route undefined, depending on how their states are set up.
- Let's say you have state
a
that has the route/a
with a default child ofb
that has the route/b
with a default child ofc
that has the route/c
. - Let's say that each of these routes have other children too.
- The way it is now, if you go to
#/a
you get a nice short route. - The other way, if you go to
#/a
you get#/a/b/c
. This could get long, and be considered ugly. - But the way it is now,
#/a
,#/a/b
, and#/a/b/c
all point to the same state. This could be confusing.
from abstract-state-router.
I think that states it well. I'm inclined to agree.
from abstract-state-router.
The hash should reflect the app state as much as possible. If I can set b
as the default child of a
but leave b
's route undefined or as an empty string I'm good.
from abstract-state-router.
Related Issues (20)
- Ignore parameters that are not used by any state HOT 3
- No way for children to depend on route parameters of ancestors HOT 2
- Eliminate references to node modules HOT 2
- Need to allow for adding custom hash fragments HOT 1
- When using root path '/' the page doesn't render on refresh HOT 9
- Why doesn't it scroll to the top when you navigate between states HOT 1
- Proposal to implement empty state HOT 4
- When using pushState routing, encodeURI should be used instead of encodeURIComponent
- Reloading current route HOT 22
- A dot/period(.) in url for a named parameter returns an error HOT 3
- Adding multiple keyed templates for a state HOT 6
- Possible to send actual objects via callback.redirect? HOT 10
- Push state routing not working with "defaultChild state with an empty route string" HOT 1
- It is possible for `makePath` to return a url that will not be matched by the router
- Non-async resolve results in confusing behavior HOT 1
- Lazy-loading states HOT 3
- State name should be optional to `state.go` HOT 4
- Get browserstack tests passing again HOT 1
- Modern JS features HOT 5
- Default values for route parameters HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from abstract-state-router.