Giter Site home page Giter Site logo

Comments (3)

TelepathicGrunt avatar TelepathicGrunt commented on June 3, 2024 2

I was copying vanilla’s bottom rendering and changing the height iirc. So I don’t know specifically which line is controlling the normals or how to fix it. It would also mean sodium isn’t supporting vanilla and many mods would be copying the same vanilla code.

Edited to word what I wanted to say better

from bumblezone.

douira avatar douira commented on June 3, 2024

The normal being given through the fluid handler api doesn't correspond to the facing (up/down/n/w/e/s). This breaks translucency sorting. I expect it to also be fixed on our end by simply distrusting the normals being passed in and recalculating them based on the actual geometry, but it's worth mentioning that the given normal is wrong.

from bumblezone.

douira avatar douira commented on June 3, 2024

Sodium is going to be working around improper usage of the API by recalculating normals for all quads given through this API. Fabric's default implementation of the API doesn't enforce it (by, for example, breaking) and is less strict than the (albeit also compliant) implementation by Sodium.

from bumblezone.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.