Programmatically changing content offset triggers TLYShyNavBar

[koenbud]

Programmatically changing content offset triggers TLYShyNavBar

[Mazyod]

@koenbud Off the top of my head, we can check in the scrollViewDidScroll: method if the scrollView is not dragging/tracking nor decelerating, that's a probably a programatic offset.

The problem with this, tho, is when you tap on the status bar. I would assume that is programatic from within the framework, and we do want to update the TLYShyNavBar..

Your solutions might be the only way, to add a freeze state... Or, even better, can you please try setting the contraction/expansion resistance to INFINITY? That should "freeze" the ShyNavBar. If that works, you can submit a PR with a new property called freeze that caches the resistance values in internal variables, and restores them when freeze is set to false. Just probably make sure if the user calls shyNavBarManager.freeze = YES twice, you don't cache the INFINITY value.

Of course, general code style conformation, docs, and testing is highly appreciated!

Let me know if I can help.

[koenbud]

Awesome, thanks for the quick reply. I'll try to take a look in the next couple of days.

[nolanw]

@Mazyod the status bar tap comes to the delegate via -scrollViewShouldScrollToTop: and -scrollViewDidScrollToTop: so it shouldn't be an issue to temporarily freeze the ShyNavBar. (Just make sure to take the subsequent scrollview delegate's response to -...ShouldScrollToTop: into account first!)

[Mazyod]

@nolanw Interesting point, thanks! Yup, that solves the tapping on statusbar issue.
I think I'll give it a shot!

[Mazyod]

I think this was resolved by introducing the disabled property on the manager.