Giter Site home page Giter Site logo

Comments (3)

mleone87 avatar mleone87 commented on September 14, 2024

that would be great and, IMHO, it should have been like that from the beginning.
Unfortunately this will have a massive impact on terraform provider so it will have to be reworked on this part from scratch

from proxmox-api-go.

Tinyblargon avatar Tinyblargon commented on September 14, 2024

Started reworking on a new Qemu disk structure in https://github.com/Tinyblargon/proxmox-api-go/tree/Overhaul-Qemu-Disks

from proxmox-api-go.

Tinyblargon avatar Tinyblargon commented on September 14, 2024

@mleone87 I've re-implemented the the disk structure.
Due to the the size of this change I was unable to keep the old disk implementation working.
Do we have any plans for moving forward with big breaking changes like this?
Currently i have marked the old implementation as deprecated. it might be better to remove it since i couldn't keep it working and it riddled with bugs that cause it to panic.

This new implementation is able to deal with:

  • linked clones
  • pass-through disks
  • virtual disks
  • cdrom (pass-through and iso file)
  • cloud-init drive

Also the logic for resizing and moving disk has been added to this project.
This means that developers can call the update function and all the CRUD operations related to disks are handled by it.
(some of these parts had to be updated as well, as they did not implement all options proxmox allows.)

I'm currently finalizing the implementation of the terraform provider.

About 70% of the code is tests, as there where many edge cases.

I have already fixed the merge conflicts.
https://github.com/Tinyblargon/proxmox-api-go/tree/Overhaul-Qemu-Disks-Merge

from proxmox-api-go.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.