Comments (3)
that would be great and, IMHO, it should have been like that from the beginning.
Unfortunately this will have a massive impact on terraform provider so it will have to be reworked on this part from scratch
from proxmox-api-go.
Started reworking on a new Qemu disk structure in https://github.com/Tinyblargon/proxmox-api-go/tree/Overhaul-Qemu-Disks
from proxmox-api-go.
@mleone87 I've re-implemented the the disk structure.
Due to the the size of this change I was unable to keep the old disk implementation working.
Do we have any plans for moving forward with big breaking changes like this?
Currently i have marked the old implementation as deprecated. it might be better to remove it since i couldn't keep it working and it riddled with bugs that cause it to panic.
This new implementation is able to deal with:
- linked clones
- pass-through disks
- virtual disks
- cdrom (pass-through and iso file)
- cloud-init drive
Also the logic for resizing and moving disk has been added to this project.
This means that developers can call the update function and all the CRUD operations related to disks are handled by it.
(some of these parts had to be updated as well, as they did not implement all options proxmox allows.)
I'm currently finalizing the implementation of the terraform provider.
About 70% of the code is tests, as there where many edge cases.
I have already fixed the merge conflicts.
https://github.com/Tinyblargon/proxmox-api-go/tree/Overhaul-Qemu-Disks-Merge
from proxmox-api-go.
Related Issues (20)
- Bug: error 400 when setting pool on a Qemu Guest
- Feature: Dynamic permission checking.
- Feature: Cache proxmox version in `Client`
- Remove: old disk code.
- Feature: Optional HA settings
- Overhaul: QemuCpu HOT 1
- Feature: Optional Protection property for Qemu VMs
- BUG: Unable to disable `qemu-guest-agent`.
- Crash: interface conversion: interface {} is string, not float64
- Re-implement: agent interface information
- Unable to Delete guest with `protection` set to `true` HOT 1
- Overhaul: Guest tags
- Bug: Duplicate mac address on two interfaces
- Overhaul: LXC
- bug: tags can't have `-` HOT 1
- Overhaul: Qemu Network interfaces. HOT 2
- Bug: setting `CloudInit.UpgradePackages` gives error on older PVE
- Bug: `ConfigQemu.Description` can't be removed
- Overhaul: Serial HOT 1
- Hide cloud-init data when no cloud-init disk is present?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from proxmox-api-go.