Parse Error: Data did not match any variant of untagged enum TelegramResponse for `getStickerSet`

[Avimitin]

Parse Error: Data did not match any variant of untagged enum TelegramResponse for `getStickerSet`

[avoonix]

Bot API 7.2 introduces "Mixed-Format Sticker Packs". This change removes is_animated and is_video from StickerSet.

I think it's enough to just remove this line:

teloxide/crates/teloxide-core/src/types/sticker_set.rs

Lines 22 to 26 in 384811a

	/// Sticker format shared by all stickers in this set.
	#[serde(flatten)]
	pub format: StickerFormat,

[WaffleLapkin]

I think this is a result of a missing #[serde(default)] on StickerKind::Regular::premium_animation:

teloxide/crates/teloxide-core/src/types/sticker.rs

Lines 64 to 67 in fb2865b

	Regular {
	/// Premium animation for the sticker, if the sticker is premium.
	premium_animation: Option<FileMeta>,
	},

[Avimitin]

But Option should have Default trait impl with None as default value? https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=ceaea5c407a5d5eb826aa6b5c3efcf92

[WaffleLapkin]

@Avimitin this is mostly irrelevant. We use serde via macros, which do not have access to the type information and can't change Deserialize implementation depending on if type implements Default or not. That's why #[serde(default)] annotation exists -- to tell the macros to use the Default impl.

[avoonix]

Is this being worked on? If not I could try to do it

[WaffleLapkin]

I don't think anyone is working on this, you may go ahead

[AH-dark]

It seems that the maintainers did not pay attention to this issue 🤔

[WaffleLapkin]

Fixed by #1040 (right, @syrtcevvi?).

[syrtcevvi]

all right