Giter Site home page Giter Site logo

Comments (9)

Templarian avatar Templarian commented on June 22, 2024 2

This was published @mAAdhaTTah @shabith! I really need to setup something that reminds me of this stuff. An AI to better manage my open source stuff. Like "That one repo that you never check has stuff."

Sorry about that!

from materialdesign-react.

Templarian avatar Templarian commented on June 22, 2024

@mAAdhaTTah Is there a convention for this prop name possibly you've seen elsewhere. Definitely would take a PR for this.

I'm assuming a lot of components run into this if you can find an example somewhere else that will make me feel better about the change.

from materialdesign-react.

mAAdhaTTah avatar mAAdhaTTah commented on June 22, 2024

@Templarian Personally, I think id would be fine, since that's the underlying attribute. For other examples, we ran into a similar issues with Downshift, which uses id and will generate a default value if one isn't provided.

from materialdesign-react.

Templarian avatar Templarian commented on June 22, 2024

@mAAdhaTTah It looks like they try to solve this issue with useOpaqueIdentifier. I'm fine merging a PR that takes in an id.

from materialdesign-react.

Templarian avatar Templarian commented on June 22, 2024

Going to re-open this until I have it published to NPM.

@mAAdhaTTah Annoy me if this is not published by Saturday afternoon please.

from materialdesign-react.

mAAdhaTTah avatar mAAdhaTTah commented on June 22, 2024

@Templarian Will do, thank you!

from materialdesign-react.

mAAdhaTTah avatar mAAdhaTTah commented on June 22, 2024

@Templarian Hope you're having a great weekend! Obvs I didn't tag you on this last weekend but maybe you have some time this one?

from materialdesign-react.

shabith avatar shabith commented on June 22, 2024

Hi @Templarian any update on this? seems like it is not published to NPM yet.

Thanks @mAAdhaTTah for your PR on this.

from materialdesign-react.

bdemirel avatar bdemirel commented on June 22, 2024

I was facing the same problem and took me some time to find this issue/PR. Thanks for the fix, but it may be useful to add a note about this on the website!

from materialdesign-react.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.