Comments (9)
This was published @mAAdhaTTah @shabith! I really need to setup something that reminds me of this stuff. An AI to better manage my open source stuff. Like "That one repo that you never check has stuff."
Sorry about that!
from materialdesign-react.
@mAAdhaTTah Is there a convention for this prop name possibly you've seen elsewhere. Definitely would take a PR for this.
I'm assuming a lot of components run into this if you can find an example somewhere else that will make me feel better about the change.
from materialdesign-react.
@Templarian Personally, I think id
would be fine, since that's the underlying attribute. For other examples, we ran into a similar issues with Downshift, which uses id
and will generate a default value if one isn't provided.
from materialdesign-react.
@mAAdhaTTah It looks like they try to solve this issue with useOpaqueIdentifier
. I'm fine merging a PR that takes in an id.
from materialdesign-react.
Going to re-open this until I have it published to NPM.
@mAAdhaTTah Annoy me if this is not published by Saturday afternoon please.
from materialdesign-react.
@Templarian Will do, thank you!
from materialdesign-react.
@Templarian Hope you're having a great weekend! Obvs I didn't tag you on this last weekend but maybe you have some time this one?
from materialdesign-react.
Hi @Templarian any update on this? seems like it is not published to NPM yet.
Thanks @mAAdhaTTah for your PR on this.
from materialdesign-react.
I was facing the same problem and took me some time to find this issue/PR. Thanks for the fix, but it may be useful to add a note about this on the website!
from materialdesign-react.
Related Issues (20)
- How do you dynamically load an Icon? HOT 14
- Invariant Violation HOT 8
- Icon prop types do not allow assignment of onClick HOT 4
- Icon is using deprecated SFC type instead of FunctionComponent type HOT 1
- [Feature request] Add default class attribute to all svg elements HOT 2
- Dynamic load icons HOT 1
- Why '--save-dev'? HOT 1
- Icon path prop not accepting strings? HOT 1
- Add 'prop-types' as a dependency (or remove it) HOT 4
- Baseline flag HOT 1
- Change/Disabled role in svg icon HOT 1
- `spin` broken in Safari HOT 5
- Build error HOT 8
- Cannot assign to read only property 'width' of object '#<Object>' icon HOT 1
- add a view-box prop HOT 1
- Can't use 'onClick' on Icon in Typescript HOT 1
- Different styles of icons (rounded, sharp, outlined)
- Does this library still need to be maintained?
- Default import of Icon crushes production build HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from materialdesign-react.