Comments (8)
I gather that the majority of users do not want persistence by default.
I actually agree with this. But having data not persisted should still be opted into I think so it's clear to the user.
Regardless, I just don't see why it's so important to change the current default instead of leaving it the way it always has been. Is there something that is causing this issue to be opened? Are there complaints or ergonomics issues for anyone's setup? Or is it just a random idea to change existing default? If the latter, there is no benefit over opting into data loss.
If the default option of using a file is a problem, we can force them to choose, but changing the default to loss of data seems like you're only causing trouble to save a few CLI arg characters. Just type the arg and move on as all others have that need ephemeral.
it's not like people lose their data.
Yes they do. They fire up Temporalite, then restart it, and wonder why their data is gone unlike the last time they used Temporalite where data survived over restart. Sure it's not production data loss or something, this isn't even a production server, but the cost of changing the default is still higher than the cost of leaving it.
from temporalite-archived.
it's not like people lose their data.
What I meant by this is that if they already had a DB, they upgrade and ephemeral is the default, the data in their DB is preserved.
I have no strong opinion, feel free to close this issue, I brought it up as a suggestion.
I don't think there's that much value in a "yolo" or "start-ephemeral" command, it doesn't save much. Having the explicit params at least informs the user what's going to happen (creating a default namespace and opting into ephemeral mode).
from temporalite-archived.
if they already had a DB, they upgrade and ephemeral is the default, the data in their DB is preserved.
I think the concern is not so much about losing the old data, but that you could conceivably upgrade and then not notice that new workflow executions are not being persisted until the next restart.
I'll go ahead and close this for now, but definitely happy to entertain new subcommands in the future if we think they bring significant value.
from temporalite-archived.
I think it's reasonable to have a default of file persistence. Even if it wasn't reasonable, it's the current expectation by the many users of this binary, no need to change it now. What's the harm of providing the single CLI arg? Especially compared to harm of incompatibly changing everyone's default to stop persisting to disk.
I don't share this preference personally even though I always use Temporalite ephemerally in my use cases.
from temporalite-archived.
Based on 0 data, I gather that the majority of users do not want persistence by default.
Reasons that could back my theory:
- temporalite is often used in CI where ephemeral is a better default
- defaulting to persisting in a non-user supplied location could lead to surprises when restarting and finding workflows being scheduled and test workflow IDs being taken
- current issue with missing permissions to write to the default location (reported by some Windows users) would be entirely avoided
- easier to upgrade versions that require schema changes
As far as breaking compat, the implication isn't too bad, it's not like people lose their data.
from temporalite-archived.
I gather that the majority of users do not want persistence by default.
I actually agree with this. But having data not persisted should still be opted into I think so it's clear to the user.
I also agree that the majority are probably using the ephemeral mode. But I also think it's important that any non-durable usage is self-documenting. This is why there is no short form of the --ephemeral
flag and no environment variable to set it by default (which I'm just now realizing we should add a code comment about).
Although it's not currently recommended, my vision is for Temporalite to be stable enough for small-scale production usage in addition to CI and local dev. I don't think we should ship defaults that cause users to second-guess whether their configuration could become unsuitable for production at any time.
from temporalite-archived.
That said we could always add a new subcommand for convenience (temporalite yolo
??) which is like start
but defaults to ephemeral, creates a default
namespace for you, and is explicitly for these throwaway use cases.
from temporalite-archived.
temporalite start-ephemeral
I think would be a great compromise here. Granted you've really only saved a space, a dash, and maybe a namespace name, heh.
from temporalite-archived.
Related Issues (20)
- github.com/temporalio/ui-server/v2-v2.5.1: 2 vulnerabilities (highest severity is: 6.1) - autoclosed HOT 1
- github.com/temporalio/ui-server/v2-v2.6.0: 2 vulnerabilities (highest severity is: 6.1) - autoclosed HOT 1
- github.com/temporalio/ui-server/v2-v2.6.2: 2 vulnerabilities (highest severity is: 6.1) - autoclosed HOT 1
- Add detach option HOT 2
- Time skipping HOT 1
- Support for user specified server/sdk versions HOT 6
- Temporalite v0.2.0 fails to install HOT 4
- github.com/temporalio/ui-server/v2-v2.7.1: 2 vulnerabilities (highest severity is: 6.1) - autoclosed HOT 1
- When building as a git submodule, temporalite docker build fails to fetch VCS status
- github.com/temporalio/ui-server/v2-v2.8.0: 2 vulnerabilities (highest severity is: 6.1) - autoclosed HOT 1
- github.com/temporalio/ui-server/v2-v2.8.1: 2 vulnerabilities (highest severity is: 6.1) - autoclosed HOT 1
- github.com/temporalio/ui-server/v2-v2.8.3: 1 vulnerabilities (highest severity is: 4.3)
- temporalite homebrew HOT 2
- Misleading error is raised when host address is already binded locally.
- Error while installing temporalite HOT 1
- Can't terminate workflows from UI
- Temporalite Repository Migration
- Unable to upgrade to Temporal 1.20 due to missing Internal frontend configuration HOT 2
- Unable to run Temporalite in an environment where $HOME is not defined
- Docker release via GitHub packages HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from temporalite-archived.