Giter Site home page Giter Site logo

Comments (11)

larrymjordan avatar larrymjordan commented on May 25, 2024 3

@cretz seems like updating go version to 1.17.3 solves the issue too without using replace. Credits to @SirUela and @amartine59

from temporalite-archived.

cretz avatar cretz commented on May 25, 2024 2

@jlegrone - I have just merged temporalio/temporal#2296 which will alleviate this statsd issue when y'all get there.

from temporalite-archived.

cretz avatar cretz commented on May 25, 2024 1

uber-go/tally#171 was merged to hopefully solve this problem. Hopefully this replace will not be needed soon. But in the meantime, go.mod on the Temporal side does have this replace and since replaces aren't transitive, it would have to be applied here too.

from temporalite-archived.

larrymjordan avatar larrymjordan commented on May 25, 2024

Awesome,
thank you @cretz

from temporalite-archived.

jlegrone avatar jlegrone commented on May 25, 2024

Yep I think this is because go mod tidy -compat=1.17 was used, which skips adding checksums needed for Go 1.16. I haven't verified yet but #20 may have fixed this.

Note that Temporalite compatibility with previous Go releases is currently on a best-effort basis and may break at any time due to internal usage of new features or the same in one of our dependencies. For example we may start making use of T.Setenv to simplify testing CLI tools like tctl that read in connection options from the environment.

from temporalite-archived.

jlegrone avatar jlegrone commented on May 25, 2024

Temporal upstream just started requiring Go 1.18, and Temporalite will need to adopt the same requirements.

Since this issue appears to only be reproducible on Go 1.16, I'm going to resolve it. Please feel free to file a new issue if similar problems crop up on Go 1.18+!

from temporalite-archived.

jackielii avatar jackielii commented on May 25, 2024

This is happening again on latest:

$ go get github.com/DataDog/temporalite/cmd/temporalite@latest
go: downloading github.com/urfave/cli/v2 v2.6.0
go: downloading github.com/temporalio/ui-server v0.13.1
go: downloading github.com/urfave/cli v1.22.5
go: downloading github.com/cpuguy83/go-md2man/v2 v2.0.2
go: downloading github.com/labstack/echo-contrib v0.12.0
go: downloading github.com/coreos/go-oidc/v3 v3.1.0
go: downloading github.com/cactus/go-statsd-client v3.2.1+incompatible
github.com/DataDog/temporalite/cmd/temporalite imports
        github.com/DataDog/temporalite/internal/liteconfig imports
        go.temporal.io/server/common/metrics imports
        github.com/cactus/go-statsd-client/statsd: ambiguous import: found package github.com/cactus/go-statsd-client/statsd in multiple modules:
        github.com/cactus/go-statsd-client v3.1.1+incompatible (/Users/jackieli/go/pkg/mod/github.com/cactus/[email protected]+incompatible/statsd)
        github.com/cactus/go-statsd-client/statsd v0.0.0-20200423205355-cb0885a1018c (/Users/jackieli/go/pkg/mod/github.com/cactus/go-statsd-client/[email protected])

I'm using 1.18:

$ go version
go version go1.18.2 darwin/arm64

from temporalite-archived.

jackielii avatar jackielii commented on May 25, 2024

hmmm. Just tried creating a new project and import the github.com/DataDog/temporalite/temporaltest package. It all worked. Same command in existing project just doesn't:

../../../go/pkg/mod/go.temporal.io/[email protected]/common/metrics/config.go:31:2: ambiguous import: found package github.com/cactus/go-statsd-client/statsd in multiple modules:
        github.com/cactus/go-statsd-client v3.1.1+incompatible (/Users/jackieli/go/pkg/mod/github.com/cactus/[email protected]+incompatible/statsd)
        github.com/cactus/go-statsd-client/statsd v0.0.0-20200423205355-cb0885a1018c (/Users/jackieli/go/pkg/mod/github.com/cactus/go-statsd-client/[email protected])

from temporalite-archived.

jackielii avatar jackielii commented on May 25, 2024

somehow I needed the following replacement directives:

replace github.com/cactus/go-statsd-client => github.com/cactus/go-statsd-client v0.0.0-20200423205355-cb0885a1018c

replace github.com/apache/thrift => github.com/apache/thrift v0.0.0-20161221203622-b2a4d4ae21c7 // indirect

from temporalite-archived.

kennedyjustin avatar kennedyjustin commented on May 25, 2024

With go get -u github.com/DataDog/temporalite am getting:

github.com/DataDog/temporalite imports
        github.com/DataDog/temporalite/internal/liteconfig imports
        go.temporal.io/server/common/metrics imports
        github.com/cactus/go-statsd-client/statsd: ambiguous import: found package github.com/cactus/go-statsd-client/statsd in multiple modules:
        github.com/cactus/go-statsd-client v3.1.1+incompatible (/Users/justin/go/pkg/mod/github.com/cactus/[email protected]+incompatible/statsd)
        github.com/cactus/go-statsd-client/statsd v0.0.0-20200423205355-cb0885a1018c (/Users/justin/go/pkg/mod/github.com/cactus/go-statsd-client/[email protected])
github.com/DataDog/temporalite imports
        github.com/DataDog/temporalite/internal/liteconfig imports
        go.temporal.io/server/common/metrics imports
        go.opentelemetry.io/otel/metric/metrictest: cannot find module providing package go.opentelemetry.io/otel/metric/metrictest
github.com/DataDog/temporalite imports
        github.com/DataDog/temporalite/internal/liteconfig imports
        go.temporal.io/server/common/metrics imports
        go.opentelemetry.io/otel/metric/sdkapi: cannot find module providing package go.opentelemetry.io/otel/metric/sdkapi
go version go1.18.1 darwin/amd64

from temporalite-archived.

jackielii avatar jackielii commented on May 25, 2024

Can we re-open this issue?

as of today, go get -u -v github.com/temporalio/temporalite/temporaltest still shows error:

$ go get -u -v github.com/temporalio/temporalite/temporaltest
Found existing alias for "go get". You should use: "gog"
github.com/temporalio/temporalite/temporaltest imports
        github.com/temporalio/temporalite imports
        github.com/temporalio/temporalite/internal/liteconfig imports
        go.temporal.io/server/common/metrics imports
        github.com/cactus/go-statsd-client/statsd: ambiguous import: found package github.com/cactus/go-statsd-client/statsd in multiple modules:
        github.com/cactus/go-statsd-client v3.1.1+incompatible (/Users/jackieli/go/pkg/mod/github.com/cactus/[email protected]+incompatible/statsd)
        github.com/cactus/go-statsd-client/statsd v0.0.0-20200423205355-cb0885a1018c (/Users/jackieli/go/pkg/mod/github.com/cactus/go-statsd-client/[email protected])

using go 1.19 in go.mod

Update:
running go get -u -v github.com/cactus/go-statsd-client@none fixes the following problem

The problem still persists. The fix didn't really help...

from temporalite-archived.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.