Comments (5)
I'll be adding a pull request with a new subpackage for building protobufs along with some other changes in the next few days.
from rust-abci.
@davebryson awesome! Just one minor pre-PR comment: consider re-exporting (pub use
) some main things, such as Request/Response types, from the abci_protobuf
sub package, so that one doesn't need to always include two crates and import from two places on the client side.
from rust-abci.
@tomtau I like the idea, but how far do you go with it? You can re-export abci
so clients can simple call use abci::ResponseInfo
, etc... But what about KVPairs
in types
and merkle
? Should they also be re-exported? This could get a bit confusing. Additionally KVPairs
mod types
should be aliased as I'll bet someone would end up with another types
mod in their code.
I've actually been pondering the whole value of the protobufs stuff living in a separate crate. Should it really be there or simply part of a submodule? Is there any real value for the protobuf message code to live in it's own crate?
from rust-abci.
Think this is addressed in #34
from rust-abci.
@zramsay pull #34 should address this issue. So you should be able to close it if you like.
from rust-abci.
Related Issues (20)
- upgrade to bytes 0.5 fails to compile
- Upgrade tokio to 0.2 fails to compile HOT 2
- Upgrade protobuf to 2.10.0
- Upgrade to protobuf 2.10.1 fails HOT 1
- rearchitected rust-abci has no tests HOT 1
- Bump protobuf to 2.11
- Transition ci to github actions
- Bump protobuf to 2.12
- bump abci to support 0.33.4
- Ideas about abci architecture
- Tests don't compile with protobuf 2.16.2
- Add a changelog? HOT 1
- Add Cargo.lock ?
- Add link to crate HOT 1
- Outdated link in Cargo.toml HOT 2
- Tendermint 0.32 ABCI support HOT 1
- Reduce amount of longs under `info` HOT 2
- Unable to compile EmptyApp example! (::protobuf::VERSION_2_8_0) HOT 1
- Reduce the number of tokio-* dependencies
- Upgrade futures dependency HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rust-abci.