Giter Site home page Giter Site logo

Comments (5)

davebryson avatar davebryson commented on May 24, 2024 1

I'll be adding a pull request with a new subpackage for building protobufs along with some other changes in the next few days.

from rust-abci.

tomtau avatar tomtau commented on May 24, 2024

@davebryson awesome! Just one minor pre-PR comment: consider re-exporting (pub use) some main things, such as Request/Response types, from the abci_protobuf sub package, so that one doesn't need to always include two crates and import from two places on the client side.

from rust-abci.

davebryson avatar davebryson commented on May 24, 2024

@tomtau I like the idea, but how far do you go with it? You can re-export abci so clients can simple call use abci::ResponseInfo, etc... But what about KVPairs in types and merkle? Should they also be re-exported? This could get a bit confusing. Additionally KVPairs mod types should be aliased as I'll bet someone would end up with another types mod in their code.

I've actually been pondering the whole value of the protobufs stuff living in a separate crate. Should it really be there or simply part of a submodule? Is there any real value for the protobuf message code to live in it's own crate?

from rust-abci.

davebryson avatar davebryson commented on May 24, 2024

Think this is addressed in #34

from rust-abci.

davebryson avatar davebryson commented on May 24, 2024

@zramsay pull #34 should address this issue. So you should be able to close it if you like.

from rust-abci.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.