Giter Site home page Giter Site logo

Comments (4)

OsmanMalik avatar OsmanMalik commented on May 25, 2024 1

Thank you @JeanKossaifi for sharing that blog post. I was wondering about the ordering of unfolding in TensorLy, and this explains it very well.

I will open a PR when the implementation is done.

from tensorly.

JeanKossaifi avatar JeanKossaifi commented on May 25, 2024

Hi @OsmanMalik -- yes this is an issue with the way the documentation is built for the backend functions. Ideally we'd need one doc per backend.

The issue here is that PyTorch does not support order in the reshape. Why do you need it for?
If you absolutely need a reshape with the order keyword in Pytorch you'd have to use a combination of transpose and reshapes which most likely would be inefficient.

from tensorly.

OsmanMalik avatar OsmanMalik commented on May 25, 2024

Hi @JeanKossaifi, I'm implementing an ALS-based function for tensor ring decomposition and was converting over code I had previously written in Matlab. Since Matlab uses Fortran ordering, I'm using order="F" to get similar behavior in Python. But I should be able to rewrite the code to avoid using the order parameter and just stick to standard ordering, which will probably be more efficient anyway.

from tensorly.

JeanKossaifi avatar JeanKossaifi commented on May 25, 2024

Indeed @OsmanMalik if you're planning to run things on GPU it would be much more efficient to stick with C ordering. I had written a blog post on this, and a Stack-Overflow post, if this helps. Happy to help adapt the formulas if you need!

As a side note, would love to have the ALS-TR in TensorLy if you're interested in opening a PR when you're done! :)

from tensorly.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.