Giter Site home page Giter Site logo

Comments (5)

andergabilondo avatar andergabilondo commented on May 22, 2024 1

Fail

Hello,
I have tried to reproduce the issue with the github pages. I achieved it partially,

The problem comes in the mobile device emulation. I created a console.log with a counter that prints on every dismiss. If you click fast in the first notification before the transition completes, the onRemoval action is not executed.

let counter = 0; ... onRemoval: () => { console.log(counter); counter++; },

In my code (haven't found the reason yet), the result is shown in the gif. The notifications are fixed and unable to remove.

Thanks for your support!

from react-notifications-component.

andergabilondo avatar andergabilondo commented on May 22, 2024

Here comes an update. The problem appears when you dismiss them quickly. The onRemoval function does not execute but the notifications are graphically dismissed. The result is a notification that is not possible to remove.

from react-notifications-component.

teodosii avatar teodosii commented on May 22, 2024

I tried on GitHub pages and I was not able to reproduce. You're saying onRemoval is not being executed but your example does not have any onRemoval callback. Could you record your screen while doing this? As gif would help. Or provide an example that I'll be able to reproduce it each time, otherwise I cannot help you.

I double checked the handling for dismissal and it's always updating the previous state which should always result in correct dismissal.

from react-notifications-component.

teodosii avatar teodosii commented on May 22, 2024

Thank you for details, will look into it but most likely will get fixed after New Year

from react-notifications-component.

teodosii avatar teodosii commented on May 22, 2024

I've tried reproducing this bug but it didn't happen to me. Not even once. Could you have a look again at that? I really don't know what would be causing this as I tried manually spamming notifications and each of them gets closed afterwards. Will close it for now and I'm waiting for your answer.

from react-notifications-component.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.