Comments (1)
I am not against any contribution. In this case it was a change which was done for the SL alpha and, as you noticed, unfinished. In an pre-patch time where everyone is complaining about changed behavior and bugs, I'd rather fix it myself than waiting on feedback loops.
Having feature PRs is more than welcome if the changes are a) close to something working (which was the case, missed only the cast bars check), b) are useful contributions and match the rest of Plater (yep) and c) are not something already being worked on and/or change bugged behavior while the PR is a feature request and not a fix for the overall issue.
It is not about credit for me. I honestly don't care as long as the result is a working Plater and I can easily add you in the next release notes for that point.
It is about the bugs I still had in the code from alpha which I was working on already. as you can see in the commit, that needed a bit more changes.
This was just the easier way. Outside of pre-patch weeks I would have had the time to work on PRs.
from plater-nameplates.
Related Issues (20)
- Classic Era PTR: Attempt to call method 'SetGradientAlpha' (a nil value) HOT 5
- Personal Resource Bar disappears when I /reload or log in HOT 1
- Enemy player frames not change (not working) HOT 1
- Buff special incorrectly showing in center of nameplate HOT 6
- Buff special "Show Timer" toggle doesn't work HOT 6
- Wrong powerbar width, there are already multiple versions HOT 1
- WoW Classic Era Update [Version 1.14.4] HOT 3
- Transparency with "Out of Range + Isn't Your Target" is bugged HOT 5
- IsSpellInRange(); lua error - Plater-v569-Retail - DF v482 - 10.2.0 HOT 1
- Healer spec (druid/sham) transparency issues on range check HOT 5
- Plater-v570-2-g6665567-Retail-DF-v482-10.2.0 LUA Errors HOT 8
- Enemy players not showing cast bar HOT 1
- Plater/libs/DF/fw.lua:3981: attempt to index local 'configInfo' (a nil value) HOT 1
- Favorite colors HOT 1
- Channeled not showing on SOD classic HOT 2
- [Feature Request] Make Friendly NPCs displayed based on Client's NPC Names setting HOT 3
- Add warning on friendly player nameplate customization limitations.
- LUA Errors 10.2.7 HOT 3
- Issue with Masque and Plater HOT 2
- [Feature Request] filter aura based on NPCID HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from plater-nameplates.