Allow `onSubmit` to be an async/Promise returning function

[terkelg]

Allow `onSubmit` to be an async/Promise returning function

[terkelg]

Hi @pvdlg.
I think this can be solved by making this function async and await the onSubmit. Can you try that? I'm open for a PR

[pvdlg]

Do you mean the onAbort function? It's a user defined function, what do you mean by making it async?

[terkelg]

Sorry it was a bit rushed. But yes, something like this

function toPrompt(type, args, opts={}) {
  return new Promise((res, rej) => {
    const p = new el[type](args);
    const onAbort = opts.onAbort || noop;
    const onSubmit = opts.onSubmit || noop;
    p.on('state', args.onState || noop);
    p.on('submit', async x => res(await onSubmit(x)));
    p.on('abort', async x => rej(await onAbort(x)));
  });
}

[pvdlg]

Oh yes that's the idea but it currently doesn't work because the on function of p (an EventEmitter) doesn't seems to support async functions.

[pvdlg]

After a bit more investigation awaiting the onSubmit function here works.

Awaiting onSubmit or onAbort in toPrompt has no effect. Is that expect? Does it make sense to you?

[terkelg]

Oh that's where we want to await. I see. Can you do a PR we can test?

[pvdlg]

Yes, I already opened it: #84

[terkelg]

Thanks! Will be a part of v1.1.0