UDF module is Hard Coded and definitions duplicated

[terraform-google-modules]

UDF module is Hard Coded and definitions duplicated

[bharathkkb]

@jaketf looks like we switched from shell script to gcloud module midway in #37 but forgot cleanup the script. I am not well versed IRL use-cases for this module but there maybe a value add in providing a default set of UDFs.

Perhaps the interface could be such that if no custom udfs are provided we use current set (this would also prevent a breaking change).

[jaketf]

I think IRL there is exactly one user of this module and they only use a modified version in an "fork".
IMO, the existing set is useless as all users should migrate to using the bigquery utils maintained versions of these UDFs or their own source SQL. We notably don't test these UDF definitions in this repo so I'm not keen to bring these forward.

[morgante]

I agree that maintaining a copy of the UDFs here doesn't make much sense.

If we wanted to allow incorporation of community UDFs it would better to facilitate import from https://github.com/GoogleCloudPlatform/bigquery-utils/tree/master/udfs/community but that seems unnecessary at this juncture.

[github-actions]

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days