Comments (6)
Cool will do; updated the name of the issue here. I'm actually seeing something possibly(?) unexpected with intersects
when I pass in simple multipolygon geometries. I'll put it in a a fresh issue though.
from terraformer.
hey @rgwozdz!
currently the library pulls out the corresponding geometry when one passes in a single GeoJSON Feature, but doesn't appear to account for input FeatureCollections in any meaningful way.
in contrast, 'real' MultiPolygon's are definitely supported as input.
my first instinct is that it'd be a bit presumptious for terraformer to assume a FeatureCollection was composed of multiple features that mimic the relationship of individual polygons within a multipolygon, but i'm happy to be convinced otherwise.
regardless, there's definitely more that could be done in the way of clarifying expected behavior so i'd be happy to steward a contribution in that form too.
from terraformer.
@jgravois - ok, this isn't a big deal to me; I actually happened upon the error as I was digging into some other behavior with intersects
. I'm happy to leave as is, but maybe we should update the doc as it appears to state that FeatureCollection is an allowable input.
If you think that update is a good idea, let me know, and I can PR.
from terraformer.
this isn't a big deal to me
understood. i definitely do appreciate you making notes and leaving breadcrumbs as you work.
PRs with tweaks to the doc in the name of clarification are always welcome. if you or a colleague end up poking around in intersects()
code someday and want to codify the expectation with regard to FeatureCollections too, all the better. 🙏
fwiw, something simple to document the behavior in #71 is warranted too.
from terraformer.
my plan is to publish a release as soon as this small doc issue and #68 are addressed.
from terraformer.
resolved by #89 🌹
from terraformer.
Related Issues (20)
- the JSDoc for a few functions and constants aren't making it to the README
- Primitive.prototype.convexHull does not support GeometryCollection
- add performance benchmarks
- typescript typings HOT 3
- The type field of the Geometry class is missing in @terraformer/arcgis HOT 2
- Add support for Z values HOT 2
- wire up github actions to run tests HOT 1
- Typescript typings for @terraformer/wkt HOT 1
- applyConverter missing? HOT 11
- Is there any replacement for Terraformer Core and Geostore? HOT 4
- polygonContainsPoint returns false for intersections. Is this intended? HOT 5
- Support Typescript HOT 1
- [typescript] PR review request for adding types into DefinitelyTyped
- `geojsonToArcGIS` has falsy checks for z-values HOT 4
- wkt not support GEOMETRYCOLLECTION HOT 4
- intersects has unexpected result with multipolygon geometry HOT 3
- this.parseError is not a function HOT 2
- invalid type signature for arcgisToGeoJSON HOT 4
- Allow for a possibility to override standard SRS warning HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from terraformer.