Giter Site home page Giter Site logo

Comments (3)

VitalyPeryatin avatar VitalyPeryatin commented on June 1, 2024 1

@terrakok I think check FragmentManager state on calling onSaveInstanceState is not possible. But we can solve the problem if we replace handler.post { } from AppNavigator to CommandBuffer and place it inside executeCommands(Array<out Command>). Like this:

fun executeCommands(commands: Array<out Command>) {
        mainHandler.post {
            navigator?.applyCommands(commands) ?: pendingCommands.add(commands)
        }
}

It will work because navigator inside CommandBuffer is clearing in onPause (100% before calling onSaveInstanceState)

PR for solving the problem: #164

from cicerone.

terrakok avatar terrakok commented on June 1, 2024

@VitalyPeryatin I think we should check FragmentManager state before applyCommandsSync if it is possible.
Looks like handler message was applied after state saving
f2de564

from cicerone.

terrakok avatar terrakok commented on June 1, 2024

Fixed in version 7.1

from cicerone.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.