Comments (3)
@terrakok I think check FragmentManager state on calling onSaveInstanceState
is not possible. But we can solve the problem if we replace handler.post { }
from AppNavigator
to CommandBuffer
and place it inside executeCommands(Array<out Command>)
. Like this:
fun executeCommands(commands: Array<out Command>) {
mainHandler.post {
navigator?.applyCommands(commands) ?: pendingCommands.add(commands)
}
}
It will work because navigator
inside CommandBuffer
is clearing in onPause
(100% before calling onSaveInstanceState
)
PR for solving the problem: #164
from cicerone.
@VitalyPeryatin I think we should check FragmentManager state before applyCommandsSync
if it is possible.
Looks like handler message was applied after state saving
f2de564
from cicerone.
Fixed in version 7.1
from cicerone.
Related Issues (20)
- No view found for id HOT 1
- error with Creator ActivityScreen HOT 1
- How to use Cicerone in sigleActivity multimodule app? HOT 3
- `AppNavigator#setupFragmentTransaction` public signature compatibility HOT 5
- Question: How to get nextFragment when moving backward?
- Migration to mavenCentral HOT 2
- AppNavigator applyCommandsSync HOT 5
- Override Router implementation
- Error when quickly changing fragments HOT 1
- I get NullPointerException when I try to set SupportAppNavigator in NavigatorHolder
- Crash in AppNavigator
- Crash in version 7.1 HOT 2
- ConcurrentModificationException
- v5 to v6+ migration guide HOT 2
- Crash in version 7.1 HOT 4
- Activity -> Fragment deeplinking
- Spelling and Grammar issues in Readme
- Remove Jetifier
- Few questions about your library
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cicerone.