Need v2 K/V secrets engine support

[terryhowe]

Need v2 K/V secrets engine support

[wknapik]

Seems to be an issue with hvac. Reported it here hvac/hvac#183.

[laurentribot]

The hvac issue is closed with adding support to k/v v2 api.
Unfortunately, without autodection of the bakend version
Perhaps hashivault modules should implement a new parameter to set the api version to use
@TerryHowe

[TerryHowe]

Yes. Docs https://hvac.readthedocs.io/en/latest/usage/secrets_engines/kv_v2.html

[drewmullen]

FYI - you can prepend your secret option in your play with data and it works fine. example:

    - name: terry howe vault read
      hashivault_read:
        secret: data/test

reads a secret at secret/test (kv2) just fine

[drewmullen]

I'm picking this issue up for hashivault_write, @TerryHowe whats the purpose of this function?
NVM, this wasnt as hard as i thought. PR inc

ansible-modules-hashivault/ansible/modules/hashivault/hashivault_write.py

Lines 86 to 104 in e3cb5f8

	def _convert_to_seconds(original_value):
	try:
	value = str(original_value)
	seconds = 0
	if 'h' in value:
	ray = value.split('h')
	seconds = int(ray.pop(0)) * 3600
	value = ''.join(ray)
	if 'm' in value:
	ray = value.split('m')
	seconds += int(ray.pop(0)) * 60
	value = ''.join(ray)
	if value:
	ray = value.split('s')
	seconds += int(ray.pop(0))
	return seconds
	except Exception:
	pass
	return original_value

also, how do you feel about me setting the version as an option and default it to version 2? defaulting to 1 as thats the majority of tests in functional/

[ventris]

I can see that support for kv v2 engine is now supported but I cant get it to work, is there any examples or documentation regarding this anywhere?

[drewmullen]

Check that pr, there's an example there

[ventris]

@drewmullen

In that example namespace is specfied which is something that only the pro version offers.
I get the error with copied example, both on read and write. Is the namespace part needed for the kv2 stuff to work?

Task:

    - name: write to kv2
      hashivault_write:
        secret: kv2/test
        data:
            password: mypass
        version: 2

TASK [write to kv2] *****************************************************************************************************************************************************************************************************
fatal: [localhost]: FAILED! => {"changed": false, "msg": "Error InvalidPath(no handler for route 'secret/data/kv2/test') writing secret/kv2/test", "rc": 1}

[drewmullen]

Looks like an issue on the vault side. Did you upgrade the mount to v2?

I'm off this week but if you're still having trouble next week I can help

*The namespace is optional for any task using this set of modules

[TerryHowe]

This issue should probably be closed.

[TerryHowe]

If there is anything else to this or problems I think a new issue would be best.