Giter Site home page Giter Site logo

Comments (6)

terwanerik avatar terwanerik commented on July 27, 2024

When are you setting the custom callback? How are you initializing the triggers? Is the callback in a custom callScope? Or is drawIt() a global (in window scope) function?

from scrolltrigger.

thaoms avatar thaoms commented on July 27, 2024

I tried both scopes, but they give the same results.

Im setting the callback like this;
I tried removing the 'once' param and simulated it with a variable but no luck.

Chart is a chart.js plugin

<canvas data-scroll-showCallback="drawIt()" data-scroll id="myChart" class="pie-chart" width="290" height="290"></canvas>

const trigger = new ScrollTrigger({
			toggle: {
				visible: 'visibleClass',
				hidden: 'hiddenClass'
			}
		});
		let first = true;

		// triggered when in view
		window.drawIt = function() {
			if(first){
				myChart.update();
				first = false;
			}

		};

What i'm trying to do: do the animation of the pie chart when it scrolls in view.

from scrolltrigger.

terwanerik avatar terwanerik commented on July 27, 2024

Alright, and when you place define the callback first, and then initialize ScrollTrigger? E.g;

let first = true;

// triggered when in view
window.drawIt = function() {
	if(first){
		myChart.update();
		first = false;
	}
};

const trigger = new ScrollTrigger({
	toggle: {
		visible: 'visibleClass',
		hidden: 'hiddenClass'
	}
});

from scrolltrigger.

thaoms avatar thaoms commented on July 27, 2024

That fixed it, so easy I didn't even see it.

Thank you!

from scrolltrigger.

terwanerik avatar terwanerik commented on July 27, 2024

Great, you could probably just set myChart as the callScope and just set data-scroll-showCallback to update() ;)

from scrolltrigger.

thaoms avatar thaoms commented on July 27, 2024

When using a custom scope it actually doesn't work, neither an empty scope or using my chart.
So I'll go with window for now.

Might be something conflicting with the chart.js plugin.

from scrolltrigger.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.