copy the title instead of holding the pointer

[tesseract-ocr]

copy the title instead of holding the pointer

[jbreiden]

change written, currently under review

[jbreiden]

Change is in Ray's hands and will eventually migrate here. The person in critical need has a copy.

[amitdo]

@jbreiden, we didn't get the patch.
https://github.com/tesseract-ocr/tesseract/blob/2c837dffc3/api/renderer.cpp#L71

[amitdo]

cc: @theraysmith

[jbreiden]

This was the patch. I strongly suspect it made it in.

--- tesseract/api/baseapi.cpp   2015-06-12 17:25:51.000000000 -0700
+++ tesseract/api/baseapi.cpp   2015-08-18 17:46:15.000000000 -0700
@@ -991,8 +991,7 @@
   }
 
   // Begin producing output
-  const char* kUnknownTitle = "";
-  if (renderer && !renderer->BeginDocument(kUnknownTitle)) {
+  if (renderer && !renderer->BeginDocument(unknown_title_)) {
     return false;
   }
 
@@ -1166,8 +1165,7 @@
   }
 
   // Begin the output
-  const char* kUnknownTitle = "";
-  if (renderer && !renderer->BeginDocument(kUnknownTitle)) {
+  if (renderer && !renderer->BeginDocument(unknown_title_)) {
     pixDestroy(&pix);
     return false;
   }
--- tesseract/api/baseapi.h     2015-03-09 15:43:40.000000000 -0700
+++ tesseract/api/baseapi.h     2015-08-18 17:52:49.000000000 -0700
@@ -879,6 +879,12 @@
                                  int timeout_millisec,
                                  TessResultRenderer* renderer,
                                  int tessedit_page_number);
+  // There's currently no way to pass a document title from the
+  // Tesseract command line, and we have multiple places that choose
+  // to set the title to an empty string. Using a single named
+  // variable will hopefully reduce confusion if the situation changes
+  // in the future.
+  const char *unknown_title_ = "";
 };  // class TessBaseAPI.
 
 /** Escape a char string - remove &<>"' with HTML codes. */
--- tesseract/api/renderer.h    2014-08-12 11:22:47.000000000 -0700
+++ tesseract/api/renderer.h    2015-08-18 17:17:41.000000000 -0700
@@ -77,7 +77,7 @@
     bool EndDocument();
 
     const char* file_extension() const { return file_extension_; }
-    const char* title() const { return title_; }
+    const char* title() const { return title_.c_str(); }
 
     /**
      * Returns the index of the last image given to AddImage
@@ -126,7 +126,7 @@
 
   private:
     const char* file_extension_;  // standard extension for generated output
-    const char* title_;           // title of document being renderered
+    STRING title_;                // title of document being renderered
     int imagenum_;                // index of last image added
 
     FILE* fout_;                  // output file pointer

[jbreiden]

Yes, it went in as part of this commit.

c1c1e42

[amitdo]

Since you originally linked to renderer.cpp, I thought that the patch will be in that file.

I'm sorry for the mistake.