@types/testing-library__cypress is breaking my CI build

[testing-library]

@types/testing-library__cypress is breaking my CI build

[weyert]

Guess, we should make cypress a peer dependency?

[jcreamer898]

Thanks @kentcdodds!

[kaiyoma]

What happened here? It looks like the PR was undone and this types package is still doing a full install of Cypress. We're seeing two different versions of Cypress in our node_modules because of this. Why aren't peer dependencies being used?

[nhducit]

I think you guys can workaround by using yarn resolution

package.json
https://yarnpkg.com/lang/en/docs/selective-version-resolutions/

  "resolutions": {
    "cypresss": "1.2.3" // use whichever version you want
  }

[kentcdodds]

(Note, that should work because the types are now within the module)

[kentcdodds]

I just made a PR: DefinitelyTyped/DefinitelyTyped#41917

Closing here because there's nothing we can do in this repo at this point :) Thanks! (Also, sorry it took me so long to address this. I kinda took a break and it's been hard to get back on top of things 😅)

[kentcdodds]

Try @testing-library/[email protected] :)

[jcreamer898]

Same issue causing our Jenkins process to asplode. Haha.

Curious, why is @types/testing-library__cypress even listed as a dependency? Shouldn't that be up to the consumer of this project to install?

I bet this would fix itself if @types/testing-library__cypress was moved to devDependencies eh?

[Niceplace]

I'm experiencing the same issue here but @testing-library/cypress": "5.0.2" is already in our devDependencies :/

[kentcdodds]

@weyert's suggestion is correct. It should be a peerDep with a very generous version range.

[jbojcic1]

I still have this issue. I had Cypress 4.12.1 and I installed @testing-library/cypress 6.0.1 which has @types/testing-library__cypress ^5.0.6 as a dependency. Ended up with two Cypress versions 4.12.1 and 5.0.0 which was breaking my CI build.