Support assertions for each DOM query

[benquarmby]

Support assertions for each DOM query

[kentcdodds]

peer would be the proper way to handle this

[gnapse]

I would be open to this. Sounds good.

Hopefully someone can take it to contribute this new feature before I or other maintainer do it, which may take a while.

[benquarmby]

Hopefully someone can take it to contribute this new feature before I or other maintainer do it, which may take a while.

I'm willing to make a contribution. My biggest concern is what I mentioned in the drawbacks section. These assertions would require a dependency on @testing-library/dom. Would you be open to having that as a production or peer dependency?

[gnapse]

Hmmm, good point.

@testing-library/core-maintainers thoughts?

[benquarmby]

peer would be the proper way to handle this

Agreed. That's the way my local test implementation works.

We can assume most consumers of @testing-library/jest-dom probably already have some version of @testing-library/dom. That said, adding a new peer dependency is technically a breaking change; The new assertions will break without it.

I can get started on a PR if everyone is OK with:

• adding a peer dependency.
• accepting a breaking change.

[gnapse]

I'm ok with that. But let's give it a day or two, to see what others have to say.

[gnapse]

@benquarmby I say go for it.

[benquarmby]

Made some progress here: main...benquarmby:jest-dom:jest-dom-query

Please ignore the VSCode settings. They're just for my personal convenience and will be removed. Still a way to go before it's ready for review.