Comments (17)
The Solarized theme in LilyTerm is a forked custom color theme. It is different with the original version of Solarized theme.
from lilyterm.
Solarized consists of a set of fixed color values that are the same everywhere and should be displayed the same everywhere, defined at http://ethanschoonover.com/solarized
If you change one of them it’s not Solarized anymore, simple as that.
from lilyterm.
OK, I'll rename it. Sorry...
from lilyterm.
No problem at all.
How about including the original Solarized as solarized
and the current version as solarized-alternative
?
from lilyterm.
OK. I'll fix it. Thanks!
from lilyterm.
Hm, I don’t get that:
{5, "solarized",
{{ 0, 0x1d1d, 0x1c1c, 0x1a1a },
{ 0, 0xb0b0, 0x2828, 0x2525 },
{ 0, 0x4f4f, 0x7a7a, 0x0000 },
{ 0, 0xa8a8, 0x6d6d, 0x0000 },
{ 0, 0x1e1e, 0x6f6f, 0xa8a8 },
{ 0, 0xa8a8, 0x2b2b, 0x6868 },
{ 0, 0x2121, 0x8080, 0x7979 },
{ 0, 0xbebe, 0xb9b9, 0xaaaa },
{ 0, 0x5050, 0x4d4d, 0x4747 },
{ 0, 0xe3e3, 0x3333, 0x3030 },
{ 0, 0x6f6f, 0xadad, 0x0000 },
{ 0, 0xdbdb, 0x8e8e, 0x0000 },
{ 0, 0x2727, 0x9090, 0xdbdb },
{ 0, 0xdbdb, 0x3838, 0x8686 },
{ 0, 0x2e2e, 0xb3b3, 0xa8a8 },
{ 0, 0xf1f1, 0xeaea, 0xd7d7 }}},
This is the original solarized color table:
$base03: #002b36;
$base02: #073642;
$base01: #586e75;
$base00: #657b83;
$base0: #839496;
$base1: #93a1a1;
$base2: #eee8d5;
$base3: #fdf6e3;
$yellow: #b58900;
$orange: #cb4b16;
$red: #dc322f;
$magenta: #d33682;
$violet: #6c71c4;
$blue: #268bd2;
$cyan: #2aa198;
$green: #859900;
Aren’t 4-value hex colors only crude approximations to the intended color scheme? Why do you use only 4 hex aka 2 bytes?
from lilyterm.
@Tetralet
I am interested in the answer to @Profpatsch question, too.
With a default lilyterm config file (moved my own away), and the solarized theme, it looks as follows for me:
This is quite different from using the default lilyterm color theme and then the base16 script to setup solarized:
from lilyterm.
I guess it’s because of the two bit representation, but most of it is certainly an optical illusion, because the background color in the second picture is darker.
Oh, and for it to be true solarized you need to fix your background color to #002b36. That’s a dark green-blue hue.
from lilyterm.
@Profpatsch
Yes, the background is different (LilyTerms' solarized and default respectively).
It isn't just an optical illusion. Here's the base16-setup after using "Solarized" in LilyTerm:
Thanks for the hint at the solarized bg color. This is certainly something else, which the "Solarized" profile in LilyTerm should provide, shouldn't it?
Using this bg color, I end up with black and grey being not really visible:
(LilyTerm's solarized theme + custom bg and the base16 setup for solarized)
Is this expected?
from lilyterm.
The Images here are the reference.
I can’t code C good enough to fix this bug myself and @Tetralet seems to be inactive atm.
from lilyterm.
@Profpatsch
The map you listed in #50 (comment) has 2_3 bytes for each color definition (2 bytes for each of red, green, blue; see (GdkColor)[https://developer.gnome.org/gdk/unstable/gdk-Colormaps-and-Colors.html#GdkColor]), whereas the HTML notation only has 1_3 bytes (00-FF for red, green, blue).
LilyTerm's definition are rgba colors, where one byte is used for alpha transparency.
This gets converted via convert_color_to_rgba (https://github.com/Tetralet/LilyTerm/blob/master/src/misc.c#L731), where the alpha value is shifted off.
I.e. 0x1d1d
becomes 0x1d
.
The colors appear to be way off from the original values.
When the light/dark themes where added initially, they matched (at least I can find matches there ;): d5d766c
But then they were changed multiple times:
git log --oneline src/profile.c|grep solarized
cf09a06 Better solarized ansi color theme.
225ecae Better solarized ansi color theme.
e3383ff Better solarized ansi color themes.
53e0da6 Better solarized ansi color themes.
d5d766c Add two new color themes: solarized dark and light.
3bd3c24 Add a new theme: "solarized". Thanks medicalwei for this idea.
Commit 225ecae also removed the light/dark variants, and only left a single one.
I will try to build LilyTerm now with the definitions from d5d766c, and see what that gives.
from lilyterm.
Cool!
Now I see, it makes perfect sense. I hope you are successful.
from lilyterm.
Ok, for one, the background of the light variant appears to be the same as with the dark one.
I am not sure, if the colors are correct otherwise, given that I do not know in which order they should appear. If you are interested and would like to investigate, I can push my changes to a branch.
from lilyterm.
Yes, please do.
from lilyterm.
@Profpatsch see above. The branch is at https://github.com/blueyed/LilyTerm/tree/solarized-themes.
from lilyterm.
The solarized theme in LilyTerm has been fixed, this issue should be fixed.
from lilyterm.
It would be nice if there were an official new version sometime soon. Atm one has to build it to have anything newer than 0.9.4.
from lilyterm.
Related Issues (20)
- URL regexes cannot be disabled
- join with directory params HOT 1
- save tabs (session) HOT 1
- Is there a way to set the font for CJK characters separately? HOT 5
- Prompt every time i close a terminal HOT 1
- copy paste keyboard HOT 2
- New tab key bindings
- Default to TERM=xterm-256color HOT 1
- Feature Request load background image (like xpm) from commandline
- Can not input Chinese punctuation properly in FreeBSD 11 HOT 2
- Vim in Lilyterm HOT 3
- NOT an issue
- Breaking escape codes in combination with neovim HOT 1
- LilyTerm closes all tabs if i press [x] on tab HOT 4
- LilyTerm closes window if i press [x] on selected tab
- Allow-bold deprecation
- LilyTerm doesn't allow setting inner window border
- Weird characters displayed on certain commands
- COLORTERM=lilyterm is not detected by programs, we should set to “truecolor” HOT 1
- Crash on start HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lilyterm.