Comments (12)
mathetake
commented on June 11, 2024
1
from wazero.
ncruces
commented on June 11, 2024
Just to confirm, interpreter passes the test, right?
from wazero.
anuraaga
commented on June 11, 2024
Yup, interpreter works fine, so only amd64 compiler is failing.
from wazero.
mathetake
commented on June 11, 2024
just went ahead and run the unit tests in the original Rust aho-corasick repo, and all passed 🤷♂️
from wazero.
mathetake
commented on June 11, 2024
well, I reproduced the error with the official unit tests with --release flag in cargo test --no-run
.__rust_start_panic(i32,i32) i32
0xa5a99: /rustc/ef71f1047e04438181d7cb925a833e2ada6ab390/library/panic_abort/src/lib.rs:96:17 (inlined)
/rustc/ef71f1047e04438181d7cb925a833e2ada6ab390/library/panic_abort/src/lib.rs:38:5
.rust_panic(i32,i32)
0xa5682: /rustc/ef71f1047e04438181d7cb925a833e2ada6ab390/library/std/src/panicking.rs:833:25
._ZN3std9panicking20rust_panic_with_hook17h173ea7d6a1f035f0E(i32,i32,i32,i32,i32,i32)
0xa55b5: /rustc/ef71f1047e04438181d7cb925a833e2ada6ab390/library/std/src/panicking.rs:803:5
._ZN3std9panicking19begin_panic_handler28_$u7b$$u7b$closure$u7d$$u7d$17h62f35ba2527ec452E(i32)
0xa44cf: /rustc/ef71f1047e04438181d7cb925a833e2ada6ab390/library/std/src/panicking.rs:659:13
._ZN3std10sys_common9backtrace26__rust_end_short_backtrace17hdd245b5cf43b7e94E(i32)
0xa43fa: /rustc/ef71f1047e04438181d7cb925a833e2ada6ab390/library/std/src/sys_common/backtrace.rs:171:18
.rust_begin_unwind(i32)
0xa4f8c: /rustc/ef71f1047e04438181d7cb925a833e2ada6ab390/library/std/src/panicking.rs:647:5
._ZN4core9panicking9panic_fmt17hb516fa06bb502322E(i32,i32)
0xa7a94: /rustc/ef71f1047e04438181d7cb925a833e2ada6ab390/library/core/src/panicking.rs:72:14
._ZN4core9panicking19assert_failed_inner17h7e440e1e2afa7d60E(i32,i32,i32,i32,i32,i32,i32)
0xae785: /rustc/ef71f1047e04438181d7cb925a833e2ada6ab390/library/core/src/panicking.rs:337:23
._ZN4core9panicking13assert_failed17h13c7c442512e8f39E(i32,i32,i32,i32,i32)
0x5a707: /rustc/ef71f1047e04438181d7cb925a833e2ada6ab390/library/core/src/panicking.rs:297:5
._ZN12aho_corasick5tests16run_search_tests17hf1210027171a9317E(i32,i32)
0xf5df: /Users/mathetake/aho-corasick/src/tests.rs:1338:13
._ZN4core3ops8function6FnOnce9call_once17hc2522d0bf33404b3E(i32)
0x53367: /Users/mathetake/aho-corasick/src/tests.rs:709:13 (inlined)
/Users/mathetake/aho-corasick/src/tests.rs:708:19 (inlined)
/rustc/ef71f1047e04438181d7cb925a833e2ada6ab390/library/core/src/ops/function.rs:250:5
._ZN4test28__rust_begin_short_backtrace17h59a53de8fec48743E(i32,i32)
0x96379: /rustc/ef71f1047e04438181d7cb925a833e2ada6ab390/library/core/src/ops/function.rs:250:5 (inlined)
/rustc/ef71f1047e04438181d7cb925a833e2ada6ab390/library/test/src/lib.rs:621:18
._ZN4test5types12RunnableTest3run17h75e43b06fc9be44fE(i32,i32)
0x96196: /rustc/ef71f1047e04438181d7cb925a833e2ada6ab390/library/test/src/types.rs:146:40
... maybe followed by omitted frames
._ZN4test8run_test17h2117ed746d4fbceeE(i32,i32,i32,i32,i32,i32,i32,i32)
0x7ac32: /rustc/ef71f1047e04438181d7cb925a833e2ada6ab390/library/test/src/lib.rs:644:60 (inlined)
/rustc/ef71f1047e04438181d7cb925a833e2ada6ab390/library/core/src/panic/unwind_safe.rs:272:9 (inlined)
/rustc/ef71f1047e04438181d7cb925a833e2ada6ab390/library/std/src/panicking.rs:554:40 (inlined)
/rustc/ef71f1047e04438181d7cb925a833e2ada6ab390/library/std/src/panicking.rs:518:19 (inlined)
/rustc/ef71f1047e04438181d7cb925a833e2ada6ab390/library/std/src/panic.rs:142:14 (inlined)
/rustc/ef71f1047e04438181d7cb925a833e2ada6ab390/library/test/src/lib.rs:644:27 (inlined)
/rustc/ef71f1047e04438181d7cb925a833e2ada6ab390/library/test/src/lib.rs:567:43 (inlined)
/rustc/ef71f1047e04438181d7cb925a833e2ada6ab390/library/test/src/lib.rs:606:17
._ZN4test7console17run_tests_console17hda31b7a2d1edfabfE(i32,i32,i32)
0x75d51: /rustc/ef71f1047e04438181d7cb925a833e2ada6ab390/library/test/src/lib.rs:380:31 (inlined)
/rustc/ef71f1047e04438181d7cb925a833e2ada6ab390/library/test/src/console.rs:329:5
._ZN4test9test_main17h38f333ea3a200455E(i32,i32,i32,i32,i32)
0x965a9: /rustc/ef71f1047e04438181d7cb925a833e2ada6ab390/library/test/src/lib.rs:143:15
._ZN4test16test_main_static17h574ee807b9b4a692E(i32,i32)
0x971c3: /rustc/ef71f1047e04438181d7cb925a833e2ada6ab390/library/test/src/lib.rs:162:5
._ZN12aho_corasick4main17h4f307d5683b5a88bE()
0x56134: /Users/mathetake/aho-corasick/src/lib.rs:1:1
._ZN3std10sys_common9backtrace28__rust_begin_short_backtrace17hf6cc62b06f47227eE(i32)
0x5cf86: /rustc/ef71f1047e04438181d7cb925a833e2ada6ab390/library/core/src/ops/function.rs:250:5 (inlined)
/rustc/ef71f1047e04438181d7cb925a833e2ada6ab390/library/std/src/sys_common/backtrace.rs:155:18
._ZN3std2rt10lang_start28_$u7b$$u7b$closure$u7d$$u7d$17h98dc82c73e380a56E.llvm.17769364131994765198(i32) i32
0x5a30e: /rustc/ef71f1047e04438181d7cb925a833e2ada6ab390/library/std/src/rt.rs:166:18
._ZN3std2rt19lang_start_internal17h9dd0d30024c12b69E(i32,i32,i32,i32,i32) i32
0x9e4e9: /rustc/ef71f1047e04438181d7cb925a833e2ada6ab390/library/core/src/ops/function.rs:284:13 (inlined)
/rustc/ef71f1047e04438181d7cb925a833e2ada6ab390/library/std/src/panicking.rs:554:40 (inlined)
/rustc/ef71f1047e04438181d7cb925a833e2ada6ab390/library/std/src/panicking.rs:518:19 (inlined)
/rustc/ef71f1047e04438181d7cb925a833e2ada6ab390/library/std/src/panic.rs:142:14 (inlined)
/rustc/ef71f1047e04438181d7cb925a833e2ada6ab390/library/std/src/rt.rs:148:48 (inlined)
/rustc/ef71f1047e04438181d7cb925a833e2ada6ab390/library/std/src/panicking.rs:554:40 (inlined)
/rustc/ef71f1047e04438181d7cb925a833e2ada6ab390/library/std/src/panicking.rs:518:19 (inlined)
/rustc/ef71f1047e04438181d7cb925a833e2ada6ab390/library/std/src/panic.rs:142:14 (inlined)
/rustc/ef71f1047e04438181d7cb925a833e2ada6ab390/library/std/src/rt.rs:148:20
.__main_void() i32
._start()```from wazero.
anuraaga
commented on June 11, 2024
just went ahead and run the unit tests in the original Rust aho-corasick repo, and all passed
Oh do you mean you ran the original unit tests compiling to wasm and using wazero? Do you have a command or tip for how to run it? Ah --no-run, cool tip.
from wazero.
mathetake
commented on June 11, 2024
managed to get the smaller reproducer like 200kb (original a few mb)
from wazero.
mathetake
commented on June 11, 2024
still wasm-tools shrink is working hard for me 😉
from wazero.
mathetake
commented on June 11, 2024
reduced to 40kb, almost there
from wazero.
mathetake
commented on June 11, 2024
ok 4kb 👯
from wazero.
mathetake
commented on June 11, 2024
finally got small enough repro
(module
(type (;0;) (func (param i32 i32 i32)))
(type (;1;) (func (param i32 i32 i32) (result i32)))
(type (;2;) (func (param i32 i32 i32 i32)))
(type (;3;) (func (param i32 i32)))
(type (;4;) (func (param i32)))
(func (;0;) (type 3) (param i32 i32)
(local i32)
i32.const 13
local.set 2
i32.const 1
i64.const 1
i64.store offset=16 align=4
local.get 2
local.get 2
i32.store16 offset=52
local.get 2
call 3
local.get 2
local.get 2
i64.load align=4
i64.store offset=88
i32.const 0
local.get 2
i32.load offset=88
i32.load offset=88
unreachable
)
(func (;1;) (type 2) (param i32 i32 i32 i32)
i32.const 0
i32.const -701700
i32.store offset=8
i32.const 1
i32.const 1
i32.store offset=8
)
(func (;2;) (type 0) (param i32 i32 i32)
(local i32 i32 v128 v128 v128 v128 v128 v128 v128 v128 v128 v128 v128 v128 v128 v128 v128 v128 i32 i32 i32 i32 i32 i32 i32 i32 i32 i32 i32 i32 i64 i32 i32 i32 i32 i32 i32 i32 i32 i32 i32 i32 i32 i32 i32 i32 i32 i32 i32 i32 i32 i32 i32 i32)
v128.const i32x4 0x53525150 0x57565554 0x5b5a5958 0x5f5e5d5c
local.set 10
v128.const i32x4 0x00000000 0x00000000 0x00000000 0x00000000
local.set 20
i32.const 0
i32.load offset=8
local.set 22
local.get 22
local.set 1
i32.const 0
local.set 28
local.get 1
local.tee 30
local.get 30
local.get 30
local.get 30
call 4
local.set 31
i32.const 0
local.get 19
v128.store align=4
i32.const 1
local.get 18
v128.store align=4
i32.const 0
local.get 17
v128.store align=4
local.get 0
local.get 16
v128.store align=4
i32.const 1
local.get 15
v128.store align=4
i32.const 1
local.get 14
v128.store align=4
i32.const 1
local.get 10
v128.store align=4
i32.const 0
local.get 9
v128.store align=4
i32.const 0
local.get 7
v128.store align=4
drop
)
(func (;3;) (type 4) (param i32)
local.get 0
local.get 0
local.get 0
local.get 0
call 1
i32.const 1
i32.const 1
i32.const 0
call 2
)
(func (;4;) (type 1) (param i32 i32 i32) (result i32)
i32.const 1
i32.const 0
local.get 2
memory.fill
i32.const 1
return
)
(memory (;0;) 19)
(export "" (func 0))
)from wazero.
mathetake
commented on June 11, 2024
I won't be able to debug this, so in case anyone try to fix, see #2201 for reproducing the bug
from wazero.
Related Issues (20)
- Please tell me how to properly handle stdio HOT 3
- GOOS=wasip1 embedding wazero succeeds with wasmtime but fails with wazero on arm64 HOT 5
- Make compilation faster HOT 8
- Support dialing sockets, udp, tcp, unix. HOT 3
- Race condition during module compilation engine HOT 7
- `wazero.NewCompilationCache` creates a `CompilationCache` instance that's not really caching anything HOT 8
- Race condition during module interpretation with `interpreter` engine HOT 1
- When using `Instantiate` & `InstantiateWithConfig` modules are removed implicitly from the in-memory cache
- Plans to support component model? HOT 4
- wasm debug build crashes HOT 9
- performance issue in browser environment HOT 3
- [help want] the program is hangup when read my net file system HOT 1
- [Question] Compilation cache over different versions HOT 1
- `unreachable` error and stack trace if compiled and extra memory, not otherwise HOT 4
- Clarification on concurrency semantics for invocations HOT 2
- `path_open` with an empty path should fail
- `path_symlink` doesn't work HOT 1
- flaky test: TestEngine_sortedCompiledModules
- Should not be able to open a directory with write
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from wazero.