Comments (12)
Nope, trim="/"
would be a bad idea for including in default theme. It would fail in some (new) permlink schemes.
from textpattern-default-theme.
Oups. But without it I got some errors by SEO tools: non corresponding canonical URLs with addresses.
from textpattern-default-theme.
Which canonical exactly is causing your SEO errors?
from textpattern-default-theme.
All if I do not set the trim
attribute.
from textpattern-default-theme.
I can't see what the problem is - I've check the canonical links on a live default theme and they are totally fine. If your issue is with ending /
slash (not sure if that is your issue) that is not actually an issue and your SEO tools are wrong.
Quote from John Mueller at Google:
"the slash after a hostname or domain name is irrelevant, you can use it or not when referring to the URL, it ends up being the same thing."
Basically, as long as you are consistent with your URL patterns and canonicals (which we are) then there is no issue.
from textpattern-default-theme.
Isn't it somehow related to this?
from textpattern-default-theme.
Probably - but from memory and for legacy reasons didn't we choose to stick to current handling and make sure it was consistently generated by all tags?
from textpattern-default-theme.
Anyway, that isn't specific to the default theme. The default theme canonicals are generated consistently and correctly. If the issue you mention is worth discussing again, it needs to be in the core Textpattern repo not here. Thanks.
from textpattern-default-theme.
I guess @cara-tm meant that something like
<link rel="canonical" href="<txp:page_url context="id, s" />">
would give you 'canonical' article/section links whatever other parameters (q
, pg
, etc) are. But trim="/"
shouldn't be necessary here.
from textpattern-default-theme.
So do I put the code you suggested in, @bloatware ? Or leave as it is now?
from textpattern-default-theme.
If everything is working I'd leave it as is :-)
from textpattern-default-theme.
OK, closing this one. Thanks all.
from textpattern-default-theme.
Related Issues (20)
- Improve the "alt" content for images HOT 1
- Error with secondpass < 1 HOT 2
- Demo files - this repo or another one? HOT 2
- Add `audio` instance? HOT 1
- json="escape" missing into tag
- Consider including CSS for Dark Mode HOT 3
- iOS Shrink to fit HOT 2
- Remove reliance on Google Fonts HOT 2
- Google Fonts in `popup_comments` and mockups HOT 1
- Convert navigation from float to flex
- Google Lighthouse reporting
- Consider a `4.9.x` branch HOT 3
- Offer the 'Zero' theme for download HOT 1
- Tag error into the latest default theme HOT 3
- favicon HOT 2
- Logical positioning to the 'older' page link HOT 1
- "Second pass < 1" error HOT 8
- Dark Mode support
- Fix stylelint in build
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from textpattern-default-theme.