Canonical links

[cara-tm]

Canonical links

[bloatware]

Nope, trim="/" would be a bad idea for including in default theme. It would fail in some (new) permlink schemes.

[cara-tm]

Oups. But without it I got some errors by SEO tools: non corresponding canonical URLs with addresses.

[philwareham]

Which canonical exactly is causing your SEO errors?

[cara-tm]

All if I do not set the trim attribute.

[philwareham]

I can't see what the problem is - I've check the canonical links on a live default theme and they are totally fine. If your issue is with ending / slash (not sure if that is your issue) that is not actually an issue and your SEO tools are wrong.

Quote from John Mueller at Google:

"the slash after a hostname or domain name is irrelevant, you can use it or not when referring to the URL, it ends up being the same thing."

source

Basically, as long as you are consistent with your URL patterns and canonicals (which we are) then there is no issue.

[bloatware]

Isn't it somehow related to this?

[philwareham]

Probably - but from memory and for legacy reasons didn't we choose to stick to current handling and make sure it was consistently generated by all tags?

[philwareham]

Anyway, that isn't specific to the default theme. The default theme canonicals are generated consistently and correctly. If the issue you mention is worth discussing again, it needs to be in the core Textpattern repo not here. Thanks.

[bloatware]

I guess @cara-tm meant that something like

<link rel="canonical" href="<txp:page_url context="id, s" />">

would give you 'canonical' article/section links whatever other parameters (q, pg, etc) are. But trim="/" shouldn't be necessary here.

[philwareham]

So do I put the code you suggested in, @bloatware ? Or leave as it is now?

[bloatware]

If everything is working I'd leave it as is :-)

[philwareham]

OK, closing this one. Thanks all.