Dynamically adding placeholders

[textualize]

Dynamically adding placeholders

[willmcgugan]

That should work. Try with the next release, which should be out this weekend.

[willmcgugan]

The API has change a bit since this example, but it shouldn't require an explicit refresh now.

[davidbrochart]

Just tried with v0.1.8:

from textual.widgets import Placeholder
from textual.layouts.grid import GridLayout

    
class Notebook(App):
    async def on_load(self, event: events.Load) -> None:
        await self.bind("q,ctrl+c", "quit", "Quit")
        await self.bind("a", "a")

    async def on_startup(self, event: events.Startup) -> None:

        self.layout = GridLayout()
        await self.push_view(View(layout=self.layout))

        self.layout.add_column(size=50, name="info")
        self.layout.add_column(fraction=1, name="cell")

        self.layout.add_row(fraction=1, name="1")

        self.layout.add_areas(
            info1="info,1",
            cell1="cell,1",
        )

        self.layout.place(
            info1=Placeholder(name="info1"),
            cell1=Placeholder(name="cell1"),
        )

    async def action_a(self):
        self.layout.add_row(fraction=1, name="2")
        self.layout.add_areas(
            info2="info,2",
            cell2="cell,2",
        )
        self.layout.place(
            info2=Placeholder(name="info2"),
            cell2=Placeholder(name="cell2"),
        )


Notebook.run(title="Notebook")

Nothing happens when I press a.
If I move the code of action_a at the end of on_startup, it works fine.

[willmcgugan]

Not sure why that is not working, I'll look in to it. In the meantime you can add the following to force a refresh of the layout:

await self.view.refresh_layout()

[davidbrochart]

Thanks, that works!

[davidbrochart]

It looks like the issue is still there:

from textual.app import App
from textual.widgets import Placeholder


class Notebook(App):
    async def on_load(self) -> None:
        await self.bind("q,ctrl+c", "quit", "Quit")
        await self.bind("a", "add_cell", "Add cell")

    async def on_mount(self) -> None:

        self.grid = await self.view.dock_grid(edge="left",  name="left")

        self.grid.add_column(size=50, name="info")
        self.grid.add_column(fraction=1, name="cell")

        self.grid.add_row(fraction=1, name="1")

        self.grid.add_areas(
            info1="info,1",
            cell1="cell,1",
        )

        self.grid.place(
            info1=Placeholder(name="info1"),
            cell1=Placeholder(name="cell1"),
        )

    async def action_add_cell(self):
        self.grid.add_row(fraction=1, name="2")
        self.grid.add_areas(
            info2="info,2",
            cell2="cell,2",
        )
        self.grid.place(
            info2=Placeholder(name="info2"),
            cell2=Placeholder(name="cell2"),
        )

Notebook.run(title="Notebook", log="textual.log")

[albertored]

Hi @willmcgugan, thanks for the amazig work!
I have almost the same use case of @davidbrochart but as he said this is not working, I tried also adding await self.view.refresh_layout() but with no luck. I spent a couple of hours digging in the code but I'm afraid I have no clue on what is the problem