Comments (3)
Hey, thanks for the suggestion.
This is somewhat related to #32. All the protocols you mentioned are also supported by Hedgedoc.
I'm not familiar with federation protocols. How does this usually work in practice ? Applications create local user accounts on-the-fly ?
@B-i-t-K maybe you've already implemented something similar before ?
Another nice integration is GitHub OAuth with org membership checking.
I'm not a big fan of implementing features that rely on third party accounts. (Especially Microsoft !)
Isn't OAuth supposed to be standard ? Specify the URL, client ID, client secret and the magic happens.
What needs to be done for GitHub specifically ? Checking whether a user belongs to a group ?
People from other teams: if your team uses federation for other services, what protocol would you like to see implemented ?
from ctfnote.
My team uses a custom gitlab-like oauth server and we have decided that we should probably port #20 (and our custom patch on top of that) to the current version of CTFNote and try to get this merged.
The provider specific implementation in our case is needed to fetch profile information so that a proper username is assigned when registering via oauth. As far as I know using plain oauth only returns a client_id and this id might not be suited as a human readable username. However, using a different oauth-provider requires only a few changes to the code and it shouldn't be a problem to maintain a custom fork for this and only support plain oauth officially.
I don't think it matters which protocols hedgehog supports since I don't think hedgehog supports being an oauth provider and adding additional protocols would mean modifying hedgehog instead of just modifying CTFNote.
from ctfnote.
@lkempf, I think it is better to start with the latest version of CTFNote and try to put the changes of #20 on top of that (so the other way around).
Moreover, you are probably talking about OAuth in CTFNote itself. XeR is talking about OAuth in Hedgedoc itself (since Hedgedoc has a separate account system, but CTFNote uses it as anonymous users). This is something completely different, but it would be nice if you can also attach Hedgedoc to the OAuth if you have OAuth configured for CTFNote.
If you want to submit a PR for the feature you are building, feel free to do so! I would happily review your changes :)
from ctfnote.
Related Issues (20)
- Large text's ::before elements overlapping horizontal scrollbars HOT 2
- Database cannot be reached HOT 1
- Tasks don't display correctly when attempting to 'work' them. HOT 6
- CTFNote 2.1.2 HOT 1
- Setup docker instance with pre existing postgresql db? HOT 2
- PostgreSQL errors HOT 2
- Past and incoming CTFs aren't displayed if a CTF with a very old date (before 1st january 1970) is created.
- Dependencies can be updated ? Could the PR dependabot has created be merged ? HOT 3
- API's start.sh doesn't honour DB_HOST/DB_PORT HOT 6
- Race condition in creating CTF channels/role in Discord
- Different Discord channel handling styles: Categorized, Forum & Threads HOT 1
- Open relevant page when clicking browser notifications
- Page title is not updated when going from a task to the task list
- Cannot delete user HOT 1
- Unit tests for import parser detection HOT 2
- Problem connecting to Hedgedoc over Apache HOT 1
- Refresh tasks when opening browser tab
- Frontend not synced with backend Discord status HOT 1
- Frontend fails to render when invalid date in CTF HOT 1
- Allow for account creation from the Discord bot. HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ctfnote.