[Feature] Add support for OIDC/SAML/LDAP

[craftbyte]

[Feature] Add support for OIDC/SAML/LDAP

[XeR]

Hey, thanks for the suggestion.

This is somewhat related to #32. All the protocols you mentioned are also supported by Hedgedoc.
I'm not familiar with federation protocols. How does this usually work in practice ? Applications create local user accounts on-the-fly ?
@B-i-t-K maybe you've already implemented something similar before ?

Another nice integration is GitHub OAuth with org membership checking.

I'm not a big fan of implementing features that rely on third party accounts. (Especially Microsoft !)
Isn't OAuth supposed to be standard ? Specify the URL, client ID, client secret and the magic happens.
What needs to be done for GitHub specifically ? Checking whether a user belongs to a group ?

People from other teams: if your team uses federation for other services, what protocol would you like to see implemented ?

[lkempf]

My team uses a custom gitlab-like oauth server and we have decided that we should probably port #20 (and our custom patch on top of that) to the current version of CTFNote and try to get this merged.

The provider specific implementation in our case is needed to fetch profile information so that a proper username is assigned when registering via oauth. As far as I know using plain oauth only returns a client_id and this id might not be suited as a human readable username. However, using a different oauth-provider requires only a few changes to the code and it shouldn't be a problem to maintain a custom fork for this and only support plain oauth officially.

I don't think it matters which protocols hedgehog supports since I don't think hedgehog supports being an oauth provider and adding additional protocols would mean modifying hedgehog instead of just modifying CTFNote.

[JJ-8]

@lkempf, I think it is better to start with the latest version of CTFNote and try to put the changes of #20 on top of that (so the other way around).

Moreover, you are probably talking about OAuth in CTFNote itself. XeR is talking about OAuth in Hedgedoc itself (since Hedgedoc has a separate account system, but CTFNote uses it as anonymous users). This is something completely different, but it would be nice if you can also attach Hedgedoc to the OAuth if you have OAuth configured for CTFNote.

If you want to submit a PR for the feature you are building, feel free to do so! I would happily review your changes :)