testsuite tag contains 2 attributes 'tests' => impossible to import into eclipse

[tguzik]

testsuite tag contains 2 attributes 'tests' => impossible to import into eclipse

[Nr18]

I was running into this issue as well, i'm not a java expert but can someone have a look at the failed test?

[dksAutodesk]

Hi -
I fixed this issue in my local copy but fixed another issue that is in general not related and may not be desirable to everyone.

In short, to fix the duplicate field, update src/com/tguzik/m2u/data/junit/TestSuite.java so the timeSpentInMilis field refers to the XStreamAsAttribute:time, not tests. The field name is correct but was just tied to a duplicate attribute name. The totalTests field refers to the attribute tests as expected.

This fix caused a test failure but I fixed that by editing the expected results. Not totally sure that editing was correct, but ... it worked. ;-) Honestly however, it took me 2 minutes to find/fix the bug and an 2 hours to figure out how to fix the tests. So... if you're game, I could give the tests some help to make them easier to diagnose.

Separately, the target JUnit tc name value was being plucked exclusively from the JMeter Thread name. This doesn't work if you're explicitly using the Samplers as test cases. So I added some code to src/com/tguzik/m2u/data/JtlToJunitConverter.java. If the sample.getThreadName() == null; use sample.getLabel()...

This works fine - but you need to include/exclude some fields from generated *.jtl results (using the custom logger) to make this fit together. I needed to get this working right away so it's a bit of a hack. Ultimately, you'd like to support a new command line parameter that could tell the tool which *.jtl field to use as the JUnit test case name.

---

Sorry for this long note. I could have just jumped right to a pull request but I'd like to hear back from you first, to see whether you'd like to consider these updates or whether I should just keep my forked version as private.

[dksAutodesk]

Is anyone watching this repo? I see there's a months-old pull request and some of these comments are really old.

[Nr18]

Exactly my question...

[dksAutodesk]

I just looked at the submissions on this repo and the most recent ones are 2 years old. It looks pretty certain it is no longer monitored by @tguzik.

@Nr18 - if you're motivated, we could create a new repo and collaborate there.

For my company's internal purposes I just made the fixed jar and archived it in our internal package system. So we're good for now. I may fork this repo to our internal git, so we can contribute to it as necessary. But that's a shame, to steal this public work and make it private; that's why I hesitate to do it.

What do you think?

dan

[Nr18]

I'm not a java developer i just use the package, @rikribbers has also created a pull request for this issue (See the reference in this thread). My plan was to wait for a week or so and then use his fork from there on, so if you are looking for a co-maintainer @rikribbers would be a better fit i guess.

[rikribbers]

I came to the same conclusion that this repo is no longer active, I needed the fix for internal usage so forked it and fixed my issue. So if you have any issues I am willing to put in some effort, however like everybody my time is also limited.

[dksAutodesk]

It sounds like we all have our private/forked solutions - not to mention our own priorities and pressures.

It's a pity to see the Open Source system break down. I guess at some point if there's enough interest, one of our forks can become the "live" stream.

Anyway, thanks for your comments and considerations.

[dksAutodesk]

ps. I'll create a fork with my fixes too.

[dksAutodesk]

errrr.... sorry for the spam...
@rikribbers - would you like me submit a pull request into your fork, with my updates?

[rikribbers]

please do so, I will merge them Gr, Rik

…

On 12 Jan 2017, at 18:42, dksAutodesk ***@***.***> wrote: errrr.... sorry for the spam... @rikribbers <https://github.com/rikribbers> - would you like me submit a pull request into your fork, with my updates? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AC5O3pN-YcesteKZXnPrhIOyauHlQ2raks5rRmYXgaJpZM4GC-vH>.