Giter Site home page Giter Site logo

Comments (6)

yaronyg avatar yaronyg commented on July 21, 2024

David owes a clean repro to Oguz et al.

from postcardapp.

deadlyfingers avatar deadlyfingers commented on July 21, 2024

There is a leveldown module that comes bundled with pouchdb - it appears we are using a duplicate in node_modules

from postcardapp.

deadlyfingers avatar deadlyfingers commented on July 21, 2024

@yaronyg - leveldown module duplicated in:
www/jxcore/node_modules/leveldown and
www/jxcore/node_modules/pouchdb/node_modules/leveldown

We need to delete the duplicate -
Reference to solution: jxcore/jxcore#597

Also for testing in desktop do I strictly need to use jx app.js or is it okay to use npm app.js in this localhost dev case?

from postcardapp.

yaronyg avatar yaronyg commented on July 21, 2024

https://github.com/thaliproject/postcardapp/blob/master/www/jxcore/package.json directly specifies leveldown 1.3.0 but it also specifies pouchdb 3.6.0. Now pouchDB 3.6.0 specifies leveldown as a dependency (see https://github.com/pouchdb/pouchdb/blob/849fd7ae440824c46d3219c90dea4e49caf08693/package.json) but it uses version 0.10.2.

That is why you end up with two different versions of leveldown.

But the real question is - why does this matter? Do we know that the two versions are conflicting?

If so there are several options:

Option 1 - Change postcard's package.json to use leveldown version 0.10.2
Option 2 - Change postcard's package.json to use leveldown version 1.4.1 and then change the pouchDB version to 5.0.0 which uses leveldown version 1.4.1.

I'd prefer option 2 but that is just me.

from postcardapp.

deadlyfingers avatar deadlyfingers commented on July 21, 2024

I got it working in localhost by deleting both 'leveldown' locations.
Then doing npm install leveldown in www/jxcore dir.

Or if I change the npm start command to use jx instead of nodemon in package.json

"start": "NODE_ENV=development jx ./app.js"

Then doing jx npm install leveldown in www/jxcore dir works in localhost.

from postcardapp.

deadlyfingers avatar deadlyfingers commented on July 21, 2024

@yaronyg option 2 (fixing leveldown versions) works in desktop - but need to copy in the right 'mockmobile.js' into thali module

from postcardapp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.