Giter Site home page Giter Site logo

Comments (7)

deadlyfingers avatar deadlyfingers commented on August 22, 2024

Look at Cordova plugin to add a done button. When editing mutli-line text the return key is for a new line and it would be nicer UX to have a keyboard 'Done' button to save changes to postcard.

from postcardapp.

deadlyfingers avatar deadlyfingers commented on August 22, 2024

This is handled by the 'inputAccessoryView' for iOS:
http://stackoverflow.com/questions/12188137/how-to-add-a-done-button-to-ios-keyboard-webview-phonegap-cordova
What I didn't notice is that Cordova has included this "Done" button in the inputAccessoryView for iOS already.

For Android the 'done' button could be added using android:imeOptions="actionDone" although this may not work with multiline editor.
http://stackoverflow.com/questions/2986387/multi-line-edittext-with-done-action-button

Alternatively the other option is to replace the multi-line editing 'textarea' with a single line input field to have the 'done' button back on Android soft keyboard. However in Postcard now I can also attach a photo so I might not want the return key to 'save' the postcard as I might want to capture a photo as well.

But if we can put a custom input view above soft keyboard with a 'Save' button it might be worth looking into creating a new Cordova plugin to target Android, iOS and Windows.

from postcardapp.

deadlyfingers avatar deadlyfingers commented on August 22, 2024

@yaronyg should we spin this out as a separate Cordova plugin in Thali project? Once that's done we can add the plugin into Postcard app.

from postcardapp.

yaronyg avatar yaronyg commented on August 22, 2024

I think we want to still have a carriage return key and per your comment on the call we want to have a 'save' button versus a 'done' button.

The link for iOS seems to argue that we can either add a button on the top of the keyboard or rename an existing key and that this can be done via config. Not sure if that is worth its own plugin.

The second link seems to argue that we can either have return or done but not both and I'm pretty sure we want return (although it's not the end of the world if we can't have it). So is your plan to get rid of return and replace it with done? What happened to send?

I also checked for Cordova plugins that handled keyboards and I can't say that I found anything particularly interesting. So what is the plan, to write native code?

from postcardapp.

deadlyfingers avatar deadlyfingers commented on August 22, 2024

Will give it a think over. So the standard keyboard plugin only gives 'next', 'prev' and 'done' options for iOS - https://github.com/apache/cordova-plugins/tree/master/keyboard
Ideally I would like to add a 'Save' button to have it dismiss the keyboard and trigger a save.
As for the config option for iOS this may refer to creating custom keyboards for apps rather than customising the inputAccessoryView?
Android will require further investigation.

from postcardapp.

yaronyg avatar yaronyg commented on August 22, 2024

Maybe for now we just stick in a save area instead of the check mark? It took me a bit to recognize that the checkmark meant save. It wasn't intuitive for me.

from postcardapp.

deadlyfingers avatar deadlyfingers commented on August 22, 2024

Yes 'Save' text at top right is quite common (with iOS at least) and a faster fix for now.

from postcardapp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.