Giter Site home page Giter Site logo

Comments (11)

mcay23 avatar mcay23 commented on May 23, 2024 1

Just wanted to let you know I got it to work. Looks like I was mixing up the .jar files, my bad. Works brilliantly now. Thanks a lot!

from asciianimator.

thatcherclough avatar thatcherclough commented on May 23, 2024

okay first of all, that is a really cool animation. for testing purposes could you send it to me? also the problem with rewriting the screen is that if you have a frame that is 10 lines long and then the next frame is 9 lines long, the 10th line is still present when displaying the second frame. i will look into another fix, possibly making the cursor clear or something else!

from asciianimator.

mcay23 avatar mcay23 commented on May 23, 2024

Here's the file
out.txt

From this repo BoardingSimulator

from asciianimator.

thatcherclough avatar thatcherclough commented on May 23, 2024

Okay thanks! I will get right to work!

from asciianimator.

thatcherclough avatar thatcherclough commented on May 23, 2024

Are you using a windows terminal or Linux terminal? You mentioned (Windows) in the title, however on asciinema it says it the OS is linux.

from asciianimator.

mcay23 avatar mcay23 commented on May 23, 2024

I am using windows. Asciinema doesn't work with windows so I ran it through WSL to record the terminal. To clarify, I'm seeing the flickering both on windows and WSL.

Here's a screen recording of the issue in windows: link

from asciianimator.

thatcherclough avatar thatcherclough commented on May 23, 2024

Alright, so I see the flickering on Windows, and because WSL runs from a windows terminal, it would make sense that the flickering is still present when running through WSL. I will work on finding a solution now!

from asciianimator.

thatcherclough avatar thatcherclough commented on May 23, 2024

So here is what I have gathered after testing:

  1. The flickering is because of the Windows terminal. When running the same command on my Mac computer, there is zero flickering.
  2. The speed at which the windows terminal prints is slower than the speed at which the Mac terminal prints. I ran the same command on both a windows and mac computer at the same time, and the mac computer finished about 5 seconds earlier (You could increase the fps on the windows machine to fix this).
  3. Removing the code that clears the screen dramatically reduces the flickering of the animation.

In order to fix the flickering, I added an option to specify if you want to clear the screen after every frame. From my experience, this removes the flickering of the animation, however it does not remove the flickering of the cursor. To fix the cursor flickering, you can go to the terminal properties and set the cursor to black.

Here is an updated JAR file. Can you test it with the argument -c set to false? thanks!

from asciianimator.

mcay23 avatar mcay23 commented on May 23, 2024

Hi, I tested the new jar. It seems like setting -c to false or true doesn't change the flickering on windows, both outputs look identical to me. Thanks.

from asciianimator.

thatcherclough avatar thatcherclough commented on May 23, 2024

Huh that’s weird. it fixed it on my windows machine. i will look into it more tomorrow!

from asciianimator.

thatcherclough avatar thatcherclough commented on May 23, 2024

After further testing and research, the flickering is happening because of the Windows terminal, not AsciiAnimator. The only setting that I could find that effected the flickering was "legacy mode". Disabling this mode seemed to reduce the flickering when compared to when it was enabled. Because this problem is with windows terminal, not AsciiAnimator, I will be closing this issue. I have just released AsciiAnimator 1.1.0 that adds the -c option which stopped the flickering for me.

from asciianimator.

Related Issues (1)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.