Comments (4)
Should a CI system be introduced?
Absolutely. I was looking into Travis CI just this morning actually.
What exactly are the requirements for the CI?
I'd like it to (at least) run a complete unit test suite, but testing the Dockerfile would also be nice. So long as I can develop and run my unit tests without having to use Docker, I'm cool with it.
Is Travis CI a decent choice? Are there better alternatives?
I've used Travis on other projects and found the GitHub integration to be excellent. I can't speak for alternatives though.
Do we want to cover the Dockerfile and the Vagrantfile?
The stickler in me says that if we're going to develop something and document it, it should be tested in the CI. I say this however knowing full well that there are currently exactly two tests for the whole application, so obviously there's a lot of work to be done here.
To be honest, I don't have a lot of experience writing tests for a Django app (yes, I'm a bad, bad man). I've written lots of tests for Python projects, but for higher-level stuff using a database and externalities like Tesseract and ImageMagick, I'm somewhat sketchy on what can be done for appropriate test coverage. If you, or anyone else have advice, examples, or even pull requests to fill this gap, it would be appreciated.
I'll leave this issue open for a few days to see if anyone else wants to offer insight. If I don't hear anything, I'll setup Travis CI and tell it to execute ./manage.py test
.
from paperless.
[...] testing the Dockerfile would also be nice. So long as I can develop and run my unit tests without having to use Docker, I'm cool with it.
This is definitely an important point: We should add Docker as another way to do things, but not to replace the existing ways and local workflows.
The stickler in me says that if we're going to develop something and document it, it should be tested in the CI. I say this however knowing full well that there are currently exactly two tests for the whole application, so obviously there's a lot of work to be done here.
This is definitely a point to expand on, but introducing CI which not only covers the unittests themselves, but also the two additional runtime-environments we support seems like a good way to move forward.
I'll leave this issue open for a few days to see if anyone else wants to offer insight. If I don't hear anything, I'll setup Travis CI and tell it to execute
./manage.py test
.
Sounds reasonable. When you have added and configured Travis, I'll update the Docker PR #39 to update the .travis.yml
file similar to how I have already tested it.
from paperless.
I know it's late, but I just added a .travis.yml file and setup Travis CI as a webhook. I had to fiddle with the tox configuration a bit because of where I've placed directories etc, but I think it's ok. If you have a cleaner/better way, feel free to issue a PR.
from paperless.
Looks like #509 may at least satisfy the Docker part of this three year old issue once it is merged.
from paperless.
Related Issues (20)
- Uploade with Webgui or App HOT 3
- docker-compose fails to build with the last version of Pipenv HOT 3
- Correnspondent picked from filename
- Docker Container Unhealthy
- Problem pulling static content with reverse proxy
- ImportError: cannot import name 'FieldDoesNotExist' from 'django.db.models' in __init__.py
- Not detecting new files via ftp only via smb
- Consumer uses 100% CPU when idle HOT 3
- [Feature] - Templates for OCR (Zonal OCR) using KULL
- Problem using docker-compose HOT 2
- gunicorn cannot read files? wrong permissions? HOT 2
- consumer not running in Synology Docker HOT 9
- Provide as Yunohost App
- Dockerfile: Unable to open /etc/sudoers: Permission denied HOT 1
- Paperless-ng is here. Thoughts on merging into master. HOT 18
- Disabling encryption failing after one file HOT 10
- Docker Install : No such file or directory 'python3 HOT 2
- Docker install: ERROR: for consumer Container "a713bc3650c5" is unhealthy.
- ERROR Error while consuming document img_20180606_204601.893.jpg: Invalid rotation (0) HOT 1
- Paperless in Kubernetes with NFS Backing
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from paperless.