Giter Site home page Giter Site logo

Comments (6)

tjgurwara99 avatar tjgurwara99 commented on May 3, 2024

Since the GCD algorithm for integers is already there, is there really a need for LCM?
For example:
For any a,b integers, let g = gcd(a,b) and l = lcm(a,b) then it is easy to prove that g x l = a x b

from c-plus-plus.

abhaysachan619 avatar abhaysachan619 commented on May 3, 2024

a*b=LCM(a,b)GCD(a,b)
LCM(a,b)=(a
b)/GCD(a,b)

from c-plus-plus.

cclauss avatar cclauss commented on May 3, 2024

Lots of talk but no pull requests:
https://github.com/TheAlgorithms/C-Plus-Plus/search?q=lcm&type=Issues

from c-plus-plus.

tjgurwara99 avatar tjgurwara99 commented on May 3, 2024

@cclauss I created one, couldn't pass the automated lint test that each pull request goes through so I deleted pull request even though I passed the exact same test on my machine. Any suggestions what I may have been missing?

from c-plus-plus.

cclauss avatar cclauss commented on May 3, 2024

Yes. My suggestion is to not give up so easily. Leave PRs open and ask for help in understanding why the are failing and how to fix the failing code. Closing the pull request gets you no closed to landing your algorithm.

from c-plus-plus.

tjgurwara99 avatar tjgurwara99 commented on May 3, 2024

This is solved in #840

from c-plus-plus.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.