Rationalize the two different implementations of heap sort

[thealgorithms]

Rationalize the two different implementations of heap sort

[cclauss]

Can we build a benchmark to prove which one is faster or better than the other?

It would be cool to have a benchmark because then we would have proof that they are the same and have the same performance for multiple datasets. Hint: I doubt it.

Such a benchmark could be extended to do side-by-side performance tests of all 19 of our sort algorithms. Benchmarks are cool and they have the power to push our contributors to optimize.

[cclauss]

Our test cases are when length < 2 so...
document.write([].isSorted()); // --> true
document.write([1].isSorted()); // --> true

Now comment out lines 10-13 and run again.

You will get the exact same results because the loop never runs.

Lines 10-13 can be deleted.

[sahilbansal17]

@cclauss It seems that both the implementations are exactly the same algorithmically.

[poyea]

Also, there's something more we can do. At least BogoSort has an isSorted function and a shuffle function. We can make use of these two functions to build our test sets for the whole sort/.

[cclauss]

;-) Are lines 10-13 needed?

Update: Proven with doctests in #171

[poyea]

;-) Are lines 10-13 needed?

If the loop starts with i=1 and compares this[i-1] with this[i] then it is, but no for the current code.

[cclauss]

Does the loop ever execute at all?

[poyea]

Yes. It's kind of an extension for the Array object. That's why we can use it directly.
https://js.do/code/438412

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale]

Please reopen this issue once you commit the changes requested or make improvements on the code. Thank you for your contributions.