Comments (7)
Could you explain why pull_request_target
is better? Is it correct that it uses "workflow yaml instructions" from the master branch, but Rust code from the feature branch?
I'm open to consider changing this, but please explain clearly the requested changes and their impact.
from rust.
Workflows triggered via pull_request_target have write permission to the target repository. They also have access to target repository secrets. The same is true for workflows triggered on pull_request from a branch in the same repository, but not from external forks. The reasoning behind the latter is that it is safe to share the repository secrets if the user creating the PR has write permission to the target repository already. Refer: github security blog
I just want to automate workflow run when any PR is opened from external fork. But it seems pull_request_target
is vulnerable to code injection or remote code execution. Let me know if we can do it some other way.
from rust.
This issue has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
from rust.
It's related to #596, let's see if it helps
from rust.
This issue has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
from rust.
Let's wait for #596
from rust.
Related Issues (20)
- Remove the algorithm list from the `README.md` file HOT 1
- Is the Travis workflow still being used? HOT 1
- Redundant & different test cases for different algorithms solving the same problem HOT 8
- Adding Physics algorithms HOT 1
- Port build_directory_md from Python to Rust HOT 7
- .
- Improving documentation formatting HOT 4
- ...and how do you use them? HOT 1
- Linked List implementation is unsound HOT 3
- github actions is in outdated version HOT 2
- Suggestion: Add a Section for Bit Manipulation Algorithms HOT 3
- Suggestion: Adding Loss functions of Machine Learning in maths folder HOT 14
- Suggestion: Add optimization functions, ml algorithms under `machine_learning` folder HOT 7
- Suggestion: Parallel Implementation HOT 3
- DIRECTORY.md is out of date HOT 9
- Many implementations are not declared as mods anywhere in the module tree HOT 1
- Add Gitpod Setup
- Add algorithm to find k-th digit in a digit string HOT 2
- Add algorithm to find a number of points in a polygon area
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rust.