Comments (5)
Sorry I wasn't clear - we are a "downstream" sdk wrapping native libraries with a javascript interface. But there may be an "upstream" (official, direct from Facebook) JS SDK. I don't know if there is or not, but you might or could check. Assuming there is one, it probably has a similar API, and if it does - for general portability of code between native SDK wrappers (us) and pure-JS code (always an option, maybe needed for react-native-web) if there is an upstream API or way they handle this, we should try to harmonize?
So stated more clearly:
- is there an official Facebook JS sdk that has anything like appevents? Looks like there is:
https://developers.facebook.com/docs/reference/javascript/FB.AppEvents.LogEvent - it is deprecated unfortunately but there is also https://developers.facebook.com/docs/facebook-pixel/reference
- if so is there a link to any similar API ?
The deprecated version has the same API, and it enforces this, not sure how it enforces it though? Does it throw?
More concretely for the Java SDK: https://developers.facebook.com/docs/unity/reference/current/FB.LogAppEvent#logpurchase
Any parameters needed to describe the event. Elements included in this dictionary can't be null
So we should definitely check input params and reject (or if we are swallowing error we should instead propagate them, are we? Can verify maybe via adb logcat or code inspection)
For future thinking: how does the new "Pixel" SDK behave when you feed it's methods bad data? quietly log? cleaning? a throw?
So a few questions just to help this library stay in harmony with the way the rest of the FB SDK ecosystem works with regard to invalid input
In the end it will probably boil down to code inspection here to make sure we are not swallowing native exceptions but are bubbling them up when/if they happen, and maybe JS code that validates input
from react-native-fbsdk-next.
Is there any Javascript API to reference off of for apis and type references ? Just curious
from react-native-fbsdk-next.
@mikehardy I'm sorry, I'm afraid I don't understand your question. Can you elaborate on your question?
from react-native-fbsdk-next.
Everyone should re-try with v6 of this library to see if it affects things, it has the up to date native libraries.
I'm going to close this as I'm not sure there is anything this module specifically can do other than stay up to date with native lib versions, but please feel free to continue sharing information on how best to use the available APIs / configurations
from react-native-fbsdk-next.
Sure, that makes sense. Thanks @mikehardy
from react-native-fbsdk-next.
Related Issues (20)
- Will this lib be updated to meet Apple's new third party sdk privacy manifest requirement? HOT 2
- Can't change to another account on login HOT 3
- iOS limited login HOT 14
- Email not retrieving from facebook login HOT 3
- Need help for the facebook sharing HOT 1
- Facebook SDK not initialized error when using react-native-fbsdk-next with Expo HOT 7
- FbLoginManager.loginwithPermissions was called with 1 arguments butt expects 3 arguments HOT 2
- LoginManager.logOut() doesn't remove app from Facebook "Business Integrations" HOT 1
- App switches automatically to limited login when updated to v13 HOT 4
- Access Token is invalid HOT 6
- React native app - Upgrade fbsdk to version 9.0.0 HOT 1
- Mobile product ads aka Advantage+ Catalog Ads not receiving params HOT 2
- Upgrading to v13.0.0 , build failed for android HOT 6
- iOS limited login does not return all possible fields HOT 1
- Invalid ID token from login response. HOT 3
- (iOS) ShareDialog.show(shareContent) does not show any sharing options. HOT 1
- (iOS) Automatic purchase event is not logging in iOS sdk 17.0.0 HOT 2
- Compiling for iOS 13.0, but module 'ExpoModulesCore' has a minimum deployment target of iOS 13.4 HOT 2
- [IOS] Missing 'Cancel' and 'Continue' buttons when login by FB app HOT 5
- iOS limited login sdk 17 HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-native-fbsdk-next.