Giter Site home page Giter Site logo

Comments (5)

mikehardy avatar mikehardy commented on July 16, 2024 1

Sorry I wasn't clear - we are a "downstream" sdk wrapping native libraries with a javascript interface. But there may be an "upstream" (official, direct from Facebook) JS SDK. I don't know if there is or not, but you might or could check. Assuming there is one, it probably has a similar API, and if it does - for general portability of code between native SDK wrappers (us) and pure-JS code (always an option, maybe needed for react-native-web) if there is an upstream API or way they handle this, we should try to harmonize?

So stated more clearly:

  • is there an official Facebook JS sdk that has anything like appevents? Looks like there is:

https://developers.facebook.com/docs/reference/javascript/FB.AppEvents.LogEvent - it is deprecated unfortunately but there is also https://developers.facebook.com/docs/facebook-pixel/reference

  • if so is there a link to any similar API ?

The deprecated version has the same API, and it enforces this, not sure how it enforces it though? Does it throw?

More concretely for the Java SDK: https://developers.facebook.com/docs/unity/reference/current/FB.LogAppEvent#logpurchase

Any parameters needed to describe the event. Elements included in this dictionary can't be null

So we should definitely check input params and reject (or if we are swallowing error we should instead propagate them, are we? Can verify maybe via adb logcat or code inspection)

For future thinking: how does the new "Pixel" SDK behave when you feed it's methods bad data? quietly log? cleaning? a throw?

So a few questions just to help this library stay in harmony with the way the rest of the FB SDK ecosystem works with regard to invalid input

In the end it will probably boil down to code inspection here to make sure we are not swallowing native exceptions but are bubbling them up when/if they happen, and maybe JS code that validates input

from react-native-fbsdk-next.

mikehardy avatar mikehardy commented on July 16, 2024

Is there any Javascript API to reference off of for apis and type references ? Just curious

from react-native-fbsdk-next.

taylorkline avatar taylorkline commented on July 16, 2024

@mikehardy I'm sorry, I'm afraid I don't understand your question. Can you elaborate on your question?

from react-native-fbsdk-next.

mikehardy avatar mikehardy commented on July 16, 2024

Everyone should re-try with v6 of this library to see if it affects things, it has the up to date native libraries.
I'm going to close this as I'm not sure there is anything this module specifically can do other than stay up to date with native lib versions, but please feel free to continue sharing information on how best to use the available APIs / configurations

from react-native-fbsdk-next.

taylorkline avatar taylorkline commented on July 16, 2024

Sure, that makes sense. Thanks @mikehardy

from react-native-fbsdk-next.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.