Comments (6)
A nasty workaround would be:
.filter((filePath) => {
try {
...whatever code you wanted to run...
} catch (er) {
// See bug https://github.com/thecodrr/fdir/issues/56
console.error(er);
throw er;
}
})
from fdir.
I am taking a look into this right now.
from fdir.
@peterbe have you tried this with .withErrors
? fdir
by default ignores all errors thrown during crawling. You can turn on errors with .withErrors
to have them passed on to the caller. This will require you to handle (or ignore) IO errors as well.
from fdir.
@peterbe have you tried this with
.withErrors
?fdir
by default ignores all errors thrown during crawling. You can turn on errors with.withErrors
to have them passed on to the caller. This will require you to handle (or ignore) IO errors as well.
I failed to notice that was an option.
Perhaps it's too late now, but I wish it'd be the other way around. I.e. errors raised by default with an option to .suppressErrors()
. If an expert user is perfectly aware of the options it doesn't matter, but newbies might miss it and then accidentally get super frustrated in debugging and doing their own try/catch to log the possible errors.
from fdir.
Perhaps remove the bug
label and add a "annoying refactor request" :)
from fdir.
errors raised by default with an option to .suppressErrors()
That is actually how it was in previous versions. My reasoning for going the opposite way was that most of the times IO errors are pretty useless (like file not found etc.) during crawling. The downside of current approach is that it captures and ignores all errors including syntax errors (like you reported). Maybe it should only handle IO errors thrown by the fs module and rethrow all other exceptions?
from fdir.
Related Issues (20)
- A big THANK YOU is in order HOT 1
- Can it return the size of each file HOT 1
- File has no extension, can not found HOT 3
- Compare to native options HOT 22
- Export type `Options` from `crawlWithOptions(dir, Options)` HOT 1
- Make a note about the `sync` api being much slower
- Remove callback API in next major HOT 1
- v7.0 Plan HOT 7
- Need to list path to symlink instead of resolved path HOT 2
- Limit files option HOT 1
- Need help debugging an issue?? with fdir HOT 4
- What's the correct way to use globbing? HOT 2
- Crawl with options group interface no longer correct in v5.2.0 (v5.1.0 was the same) HOT 1
- Ideas for mocking HOT 1
- [Feature] glob/crawl by symlink path, not real path HOT 7
- Sorting based on date, name, size etc
- Issue with SharePoint project accessible over the network HOT 2
- Invalid reference of TypeScript types HOT 2
- Feature request: pass picomatch to the builder HOT 3
- Avoiding double backslash
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fdir.